Fix code highlighting in system-dark theme mode - #29
Merged
Merged
Conversation
The hljs light override selector `:root:not([data-theme="dark"])` matched unconditionally in system mode (no data-theme attribute), forcing dark text on dark backgrounds. Remove the ungated selector — the media-query-gated copy already handles system-light correctly. Also: add `color-scheme` CSS property for native UI elements, and introduce `--theme-link` variable so markdown link color adapts to the active theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:root:not([data-theme="dark"])selector matched unconditionally when nodata-themeattribute was set, forcing near-black text on dark backgroundscolor-schemeCSS property to all three theme blocks so native UI elements (scrollbars, form controls, selection) render correctly--theme-linkvariable (#818cf8dark /#4f46e5light) so markdown link color adapts to the active themeTest plan