Extract chatStore.ts WebSocket handlers into domain modules - #28
Merged
Merged
Conversation
Break the 1307-line monolithic chatStore into a thin dispatcher (484 lines)
plus domain-specific handler and helper modules:
- handlers/streamingHandlers.ts — thinking, token, tool_use, tool_result, done, stopped, error
- handlers/sessionHandlers.ts — 8 session lifecycle handlers + answer_injected
- handlers/panelHandlers.ts — plan_update, subagent_start/complete, hoa_progress
- handlers/auxiliaryHandlers.ts — interaction, file_changed, notifications, background_tasks
- helpers/blockHelpers.ts — panel block append/update, auto-close timers
- helpers/bufferReplay.ts — session reconnect replay, deriveStatus, extractTodos
Eliminates all 18 `as any` casts via proper Extract<WSMessage, { type }> narrowing.
Deduplicates done/stopped panel cleanup into shared finalizeRunningPanels().
No component import changes — purely internal reorganization.
Update web-ui.md stores section and nerve-dev SKILL.md project layout to reflect the new handlers/ and helpers/ directory structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleWSMessageswitch fromchatStore.ts(1307→484 lines) into 4 domain-specific handler modules + 2 helper modulesas anycasts via properExtract<WSMessage, { type }>discriminated union narrowingdone/stoppedpanel cleanup into sharedfinalizeRunningPanels()New file structure
Test plan
npm run buildpasses (tsc + vite)