Repository navigation
Keep the new thread heading above the keyboard - #18
Closed
Claudesaul wants to merge 3 commits into
Closed
Claudesaul wants to merge 3 commits into
Claudesaul wants to merge 3 commits into
Conversation
github-actions
Bot
added
vouch:trusted
Claudesaul
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iPhone, the "What should we build in…" heading vanished while there was still room for it, taking the project and machine pickers with it.
With the keyboard up, the composer drops 34pt onto the keyboard, but the free space sum still counted that 34pt as taken. On an iPhone 18 Pro Max, an image and two lines of text left 208pt free and the screen reported 174pt, under its 180pt cutoff. The 180pt also asked for more than the heading needs, so a full prompt lost it with 186pt clear.
Now the sum matches what's on screen, and the cutoff is 156pt, which is the heading plus its top padding. The heading stays in place until it really can't fit. The layout and pickers are unchanged.
This is a small fix under the obvious bug exception: the screen was measuring its own free space wrong.
Recording: tapping into a long draft with an image, then tapping the project.
To reproduce, start a new thread, add an image, type two lines and tap the box. I logged the numbers on an iPhone 18 Pro Max simulator on iOS 27 against a scratch server, then ran the same steps on current
mainand on this branch. The mobile thread tests, typecheck and lint pass. I didn't check Android, iPad or landscape. On a smaller iPhone a full composer can leave too little room, so the heading can still hide there.