Fix Projects screen: weight keys 1–3 are swallowed by screen-jump nav#79
Merged
Merged
Conversation
On the projects screen weights 1, 2, and 3 were unreachable: the global `1`/`2`/`3` screen-jump match in `key_normal` ran and returned before the screen-local `key_projects` handler, swallowing those digits as navigation. Only 0, 4, and 5 fell through, making it impossible to set a project weight below 4 without parking it at 0. Dispatch to `key_projects` before the global digit jump, so all of 0–5 set weight on the projects screen. Tab remains the primary screen switcher, and 1/2/3 still jump directly from the cockpit and tasks screens where digits mean nothing else. The footer already advertises `tab` and `0-5 weight`, so no hint changes are needed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GcffCF1aNUFRydvicoagRX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: project weight keys 1–3 are now reachable on the Projects screen.
Root cause: in key_normal (crates/voro/src/app.rs), the global 1/2/3 screen-jump match ran and returned before dispatching to the screen-local key_projects handler, so on the Projects screen those digits were swallowed as navigation. Only 0/4/5 fell through, making weights 1–3 impossible to set (below 4 you could only park at 0).
Change: give the screen-local handler first refusal — dispatch to key_projects (which maps 0–5 to weight) before the global 1/2/3 jump. Tab stays the primary screen switcher; 1/2/3 still jump directly from the cockpit and tasks screens, where digits mean nothing in normal mode. Task-priority digits (0–3) live in the Detail popup's key_detail, a separate mode, so they are untouched. The footer already advertises 'tab' and '0-5 weight', so no ui.rs hint changes were needed.
Verification: extended digit_on_projects_screen_sets_weight_through_the_store to assert 1/2/3 set weight through the store, and updated tab_and_digits_move_between_the_three_screens (which asserted 1 jumps to Cockpit from the Projects screen — the removed behavior) to test jumps from the task-oriented screens and tab as the way out of Projects. cargo test --workspace (188 + 193 pass), cargo clippy --workspace --all-targets -- -D warnings clean, cargo fmt --check clean.
Branch: worktree-fix-projects-weight-keys