Excessive logging of include errors

[juliusknorr]

Steps to reproduce

Enable app on latest version (8.0.0)

Expected behaviour

No errors

Actual behaviour

Tons of logs for almost every request, but not ending up in sentry:

{
  "reqId": "i0iKODT1U4tXRSnUoMQR",
  "level": 3,
  "time": "2021-07-15T13:02:10+00:00",
  "remoteAddr": "",
  "user": "--",
  "app": "PHP",
  "method": "",
  "url": "--",
  "message": "include(/var/www/nextcloud/apps/updatenotification/composer/composer/../composer/InstalledVersions.php): failed to open stream: No such file or directory at /var/www/nextcloud/lib/composer/composer/ClassLoader.php#480",
  "userAgent": "--",
  "version": "22.0.0.11",
  "exception": {
    "Exception": "Error",
    "Message": "include(/var/www/nextcloud/apps/updatenotification/composer/composer/../composer/InstalledVersions.php): failed to open stream: No such file or directory at /var/www/nextcloud/lib/composer/composer/ClassLoader.php#480",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/nextcloud/lib/composer/composer/ClassLoader.php",
        "line": 480,
        "function": "onError",
        "class": "OC\\Log\\ErrorHandler",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/lib/composer/composer/ClassLoader.php",
        "line": 480,
        "function": "include"
      },
      {
        "file": "/var/www/nextcloud/lib/composer/composer/ClassLoader.php",
        "line": 346,
        "function": "Composer\\Autoload\\includeFile"
      },
      {
        "function": "loadClass",
        "class": "Composer\\Autoload\\ClassLoader",
        "type": "->"
      },
      {
        "function": "spl_autoload_call"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/vendor/jean85/pretty-package-versions/src/PrettyVersions.php",
        "line": 46,
        "function": "method_exists"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/vendor/jean85/pretty-package-versions/src/PrettyVersions.php",
        "line": 19,
        "function": "checkProvidedPackages",
        "class": "Jean85\\PrettyVersions",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/vendor/sentry/sentry/src/ClientBuilder.php",
        "line": 79,
        "function": "getVersion",
        "class": "Jean85\\PrettyVersions",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/vendor/sentry/sentry/src/ClientBuilder.php",
        "line": 87,
        "function": "__construct",
        "class": "Sentry\\ClientBuilder",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/vendor/sentry/sentry/src/functions.php",
        "line": 17,
        "function": "create",
        "class": "Sentry\\ClientBuilder",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/lib/AppInfo/Application.php",
        "line": 71,
        "function": "Sentry\\init"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 160,
        "function": "OCA\\Sentry\\AppInfo\\{closure}",
        "class": "OCA\\Sentry\\AppInfo\\Application",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 118,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 127,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 454,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/ServerContainer.php",
        "line": 145,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Support/CrashReport/Registry.php",
        "line": 126,
        "function": "query",
        "class": "OC\\ServerContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Support/CrashReport/Registry.php",
        "line": 81,
        "function": "loadLazyProviders",
        "class": "OC\\Support\\CrashReport\\Registry",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Log.php",
        "line": 232,
        "function": "delegateBreadcrumb",
        "class": "OC\\Support\\CrashReport\\Registry",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Log.php",
        "line": 191,
        "function": "log",
        "class": "OC\\Log",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/legacy/OC_App.php",
        "line": 181,
        "function": "debug",
        "class": "OC\\Log",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/legacy/OC_App.php",
        "line": 139,
        "function": "loadApp",
        "class": "OC_App",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Console/Application.php",
        "line": 119,
        "function": "loadApps",
        "class": "OC_App",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/console.php",
        "line": 98,
        "function": "loadCommands",
        "class": "OC\\Console\\Application",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/occ",
        "line": 11,
        "args": [
          "/var/www/nextcloud/console.php"
        ],
        "function": "require_once"
      }
    ],
    "File": "/var/www/nextcloud/lib/private/Log/ErrorHandler.php",
    "Line": 92,
    "CustomMessage": "--"
  }
}
{
  "reqId": "i0iKODT1U4tXRSnUoMQR",
  "level": 3,
  "time": "2021-07-15T13:02:10+00:00",
  "remoteAddr": "",
  "user": "--",
  "app": "PHP",
  "method": "",
  "url": "--",
  "message": "include(): Failed opening '/var/www/nextcloud/apps/updatenotification/composer/composer/../composer/InstalledVersions.php' for inclusion (include_path='/var/www/nextcloud/apps-extra/news/vendor/pear/net_url2:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Crypt_Blowfish:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Date:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Exception:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Idna:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Imap_Client:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_ListHeaders:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Mail:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_ManageSieve:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Mime:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Nls:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Secret:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Smtp:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Socket_Client:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Stream:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Stream_Filter:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Stream_Wrapper:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Stringprep:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Support:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Text_Filter:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Text_Flowed:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Translation:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Util:/var/www/nextcloud/3rdparty/pear/archive_tar:/var/www/nextcloud/3rdparty/pear/console_getopt:/var/www/nextcloud/3rdparty/pear/pear-core-minimal/src:/var/www/nextcloud/3rdparty/pear/pear_exception:/var/www/nextcloud/apps:/var/www/nextcloud/apps-extra') at /var/www/nextcloud/lib/composer/composer/ClassLoader.php#480",
  "userAgent": "--",
  "version": "22.0.0.11",
  "exception": {
    "Exception": "Error",
    "Message": "include(): Failed opening '/var/www/nextcloud/apps/updatenotification/composer/composer/../composer/InstalledVersions.php' for inclusion (include_path='/var/www/nextcloud/apps-extra/news/vendor/pear/net_url2:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Crypt_Blowfish:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Date:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Exception:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Idna:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Imap_Client:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_ListHeaders:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Mail:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_ManageSieve:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Mime:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Nls:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Secret:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Smtp:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Socket_Client:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Stream:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Stream_Filter:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Stream_Wrapper:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Stringprep:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Support:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Text_Filter:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Text_Flowed:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Translation:/var/www/nextcloud/apps-extra/mail/vendor/pear-pear.horde.org/Horde_Util:/var/www/nextcloud/3rdparty/pear/archive_tar:/var/www/nextcloud/3rdparty/pear/console_getopt:/var/www/nextcloud/3rdparty/pear/pear-core-minimal/src:/var/www/nextcloud/3rdparty/pear/pear_exception:/var/www/nextcloud/apps:/var/www/nextcloud/apps-extra') at /var/www/nextcloud/lib/composer/composer/ClassLoader.php#480",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/nextcloud/lib/composer/composer/ClassLoader.php",
        "line": 480,
        "function": "onError",
        "class": "OC\\Log\\ErrorHandler",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/lib/composer/composer/ClassLoader.php",
        "line": 480,
        "function": "include"
      },
      {
        "file": "/var/www/nextcloud/lib/composer/composer/ClassLoader.php",
        "line": 346,
        "function": "Composer\\Autoload\\includeFile"
      },
      {
        "function": "loadClass",
        "class": "Composer\\Autoload\\ClassLoader",
        "type": "->"
      },
      {
        "function": "spl_autoload_call"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/vendor/jean85/pretty-package-versions/src/PrettyVersions.php",
        "line": 46,
        "function": "method_exists"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/vendor/jean85/pretty-package-versions/src/PrettyVersions.php",
        "line": 19,
        "function": "checkProvidedPackages",
        "class": "Jean85\\PrettyVersions",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/vendor/sentry/sentry/src/ClientBuilder.php",
        "line": 79,
        "function": "getVersion",
        "class": "Jean85\\PrettyVersions",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/vendor/sentry/sentry/src/ClientBuilder.php",
        "line": 87,
        "function": "__construct",
        "class": "Sentry\\ClientBuilder",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/vendor/sentry/sentry/src/functions.php",
        "line": 17,
        "function": "create",
        "class": "Sentry\\ClientBuilder",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/apps-extra/sentry/lib/AppInfo/Application.php",
        "line": 71,
        "function": "Sentry\\init"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 160,
        "function": "OCA\\Sentry\\AppInfo\\{closure}",
        "class": "OCA\\Sentry\\AppInfo\\Application",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 118,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 127,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 454,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/ServerContainer.php",
        "line": 145,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Support/CrashReport/Registry.php",
        "line": 126,
        "function": "query",
        "class": "OC\\ServerContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Support/CrashReport/Registry.php",
        "line": 81,
        "function": "loadLazyProviders",
        "class": "OC\\Support\\CrashReport\\Registry",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Log.php",
        "line": 232,
        "function": "delegateBreadcrumb",
        "class": "OC\\Support\\CrashReport\\Registry",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Log.php",
        "line": 191,
        "function": "log",
        "class": "OC\\Log",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/legacy/OC_App.php",
        "line": 181,
        "function": "debug",
        "class": "OC\\Log",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/legacy/OC_App.php",
        "line": 139,
        "function": "loadApp",
        "class": "OC_App",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Console/Application.php",
        "line": 119,
        "function": "loadApps",
        "class": "OC_App",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/console.php",
        "line": 98,
        "function": "loadCommands",
        "class": "OC\\Console\\Application",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/occ",
        "line": 11,
        "args": [
          "/var/www/nextcloud/console.php"
        ],
        "function": "require_once"
      }
    ],
    "File": "/var/www/nextcloud/lib/private/Log/ErrorHandler.php",
    "Line": 92,
    "CustomMessage": "--"
  }
}

[ChristophWurst]

But isn't this also a legit error? Why does updatenotification not have those files?

[juliusknorr]

Indeed, might be a conflict between composer v2 used in server with the apps individual composer autoloaders which seems to be all still built with v1.

[juliusknorr]

Ok, so sentry/sentry pulls in Jean85/pretty-package-versions@2.x which is only compatible with composer v2 it seems https://github.com/Jean85/pretty-package-versions#compatibility.

[ChristophWurst]

Ok, so sentry/sentry pulls in Jean85/pretty-package-versions@2.x which is only compatible with composer v2 it seems https://github.com/Jean85/pretty-package-versions#compatibility.

That's easy to fix, Sentry allow any v1.x or 2.x, so I downgraded that package: #335

[ChristophWurst]

The problem is actually at https://github.com/nextcloud/server/blob/fa56c13484afa1baf908b93ed5b6990c6a0e9ad6/apps/settings/composer/composer/autoload_static.php#L24. We have our static autoloaders and they point to a file that does not exist in the vendored apps' composer directories. I'll see if we should generate and commit all composer files.

[ChristophWurst]

Obsolete