fix: remove invalid dropdown aria-expanded#1391
Open
terminalchai wants to merge 2 commits into
Open
Conversation
Collaborator
|
As I understand it, this attribute should be added when the backing element is a |
Collaborator
|
Removing aria-expanded will also break some of the css for select-one/select-multiple setups |
Contributor
Author
|
Updated this to address the select-element concern:
Tests run locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the problem:
Choices renders invalid HTML for a simple text input because the dropdown wrapper gets an unsupported
aria-expandedattribute.Steps to reproduce:
Choiceson a text input.aria-expandedusage on the dropdown wrapper.This is my solution:
Remove
aria-expandedfrom the dropdown wrapper and stop toggling it in the dropdown component, while keeping unit coverage aligned with the valid markup.Testing
Closes #1016