Skip to content

Stabilize StarWars subscription tests against CI timing flake #9915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glen-84 merged 1 commit into from
Jun 15, 2026
+21 −35
Merged

Stabilize StarWars subscription tests against CI timing flake #9915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 21 additions & 35 deletions ...ocolate/Core/test/Execution.Tests/Integration/StarWarsCodeFirst/StarWarsCodeFirstTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,8 +822,6 @@ public async Task SubscribeToReview()
""",
TestContext.Current.CancellationToken);

// Get the enumerator before publishing so the consumer is registered
// and won't race with event dispatch.
await using var enumerator = subscriptionResult.ReadResultsAsync().GetAsyncEnumerator(
TestContext.Current.CancellationToken);

Expand Down Expand Up @@ -870,6 +868,9 @@ ... on Review {
""",
TestContext.Current.CancellationToken);

await using var enumerator = subscriptionResult.ReadResultsAsync().GetAsyncEnumerator(
TestContext.Current.CancellationToken);

await executor.ExecuteAsync(
"""
mutation {
Expand All @@ -881,17 +882,10 @@ await executor.ExecuteAsync(
""",
TestContext.Current.CancellationToken);

OperationResult? eventResult = null;

using (var cts = new CancellationTokenSource(2000))
{
await foreach (var queryResult in
subscriptionResult.ReadResultsAsync().WithCancellation(cts.Token))
{
eventResult = queryResult;
break;
}
}
Assert.True(await enumerator.MoveNextAsync().AsTask().WaitAsync(
TimeSpan.FromSeconds(30),
TestContext.Current.CancellationToken));
var eventResult = enumerator.Current;

snapshot.Add(eventResult);

Expand Down Expand Up @@ -922,6 +916,9 @@ fragment SomeFrag on Review {
""",
TestContext.Current.CancellationToken);

await using var enumerator = subscriptionResult.ReadResultsAsync().GetAsyncEnumerator(
TestContext.Current.CancellationToken);

await executor.ExecuteAsync(
"""
mutation {
Expand All @@ -933,17 +930,10 @@ await executor.ExecuteAsync(
""",
TestContext.Current.CancellationToken);

OperationResult? eventResult = null;

using (var cts = new CancellationTokenSource(2000))
{
await foreach (var queryResult in
subscriptionResult.ReadResultsAsync().WithCancellation(cts.Token))
{
eventResult = queryResult;
break;
}
}
Assert.True(await enumerator.MoveNextAsync().AsTask().WaitAsync(
TimeSpan.FromSeconds(30),
TestContext.Current.CancellationToken));
var eventResult = enumerator.Current;

snapshot.Add(eventResult);

Expand Down Expand Up @@ -980,6 +970,9 @@ public async Task SubscribeToReview_With_Variables()
.Build(),
TestContext.Current.CancellationToken);

await using var enumerator = subscriptionResult.ReadResultsAsync().GetAsyncEnumerator(
TestContext.Current.CancellationToken);

await executor.ExecuteAsync(
"""
mutation {
Expand All @@ -991,17 +984,10 @@ await executor.ExecuteAsync(
""",
TestContext.Current.CancellationToken);

OperationResult? eventResult = null;

using (var cts = new CancellationTokenSource(2000))
{
await foreach (var queryResult in
subscriptionResult.ReadResultsAsync().WithCancellation(cts.Token))
{
eventResult = queryResult;
break;
}
}
Assert.True(await enumerator.MoveNextAsync().AsTask().WaitAsync(
TimeSpan.FromSeconds(30),
TestContext.Current.CancellationToken));
var eventResult = enumerator.Current;

snapshot.Add(eventResult);

Expand Down
Loading