Skip to content

Stabilize @defer overlap HTTP tests with instant initial fields #9905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glen-84 merged 1 commit into from
Jun 12, 2026
+3 −6
Merged

Stabilize @defer overlap HTTP tests with instant initial fields #9905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/HotChocolate/AspNetCore/test/AspNetCore.Tests/DeferOverHttpTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,7 +1169,6 @@ public async Task Defer_Overlap_Multipart_Legacy_Format()
{
product {
name
description
}
... @defer(label: "foo") {
product {
Expand Down Expand Up @@ -1205,7 +1204,7 @@ ... @defer(label: "foo") {
---
Content-Type: application/json; charset=utf-8

{"data":{"product":{"name":"Abc","description":"Abc desc"}},"hasNext":true}
{"data":{"product":{"name":"Abc"}},"hasNext":true}
---
Content-Type: application/json; charset=utf-8

Expand All @@ -1230,7 +1229,6 @@ public async Task Defer_Overlap_EventStream_Legacy_Format()
{
product {
name
description
}
... @defer(label: "foo") {
product {
Expand Down Expand Up @@ -1258,7 +1256,7 @@ ... @defer(label: "foo") {
var content = await response.Content.ReadAsStringAsync(TestContext.Current.CancellationToken);

Assert.Contains(
"\"data\":{\"product\":{\"name\":\"Abc\",\"description\":\"Abc desc\"}}",
"\"data\":{\"product\":{\"name\":\"Abc\"}},\"hasNext\":true",
content,
StringComparison.Ordinal);
Assert.Contains(
Expand All @@ -1283,7 +1281,6 @@ public async Task Defer_Overlap_JsonLines_Legacy_Format()
{
product {
name
description
}
... @defer(label: "foo") {
product {
Expand Down Expand Up @@ -1315,7 +1312,7 @@ ... @defer(label: "foo") {
.Add(content, "Response")
.MatchInline(
"""
{"data":{"product":{"name":"Abc","description":"Abc desc"}},"hasNext":true}
{"data":{"product":{"name":"Abc"}},"hasNext":true}
{"incremental":[{"data":{"product":{"name":"Abc","description":"Abc desc","reviews":[{"rating":5}]}},"path":[],"label":"foo"}],"hasNext":false}

""");
Expand Down
Loading