Surface clearer errors for invalid node IDs

src/HotChocolate/Core/src/Execution.Abstractions/Execution/Relay/NodeIdInvalidValueException.cs

@@ -0,0 +1,8 @@
+namespace HotChocolate.Execution.Relay;
+
+public sealed class NodeIdInvalidValueException(string typeName, object value)
+    : GraphQLException(ErrorBuilder.New()
+        .SetMessage(
+            $"The value could not be formatted into an ID for the type `{typeName}`.")
+        .SetExtension("originalValue", value.ToString())
+        .Build());

src/HotChocolate/Core/src/Types/Execution/Extensions/OperationContextExtensions.cs

@@ -22,7 +22,9 @@ public OperationContext ReportError(
             {
                 foreach (var error in ex.Errors)
                 {
-                    context.ReportError(error, resolverContext);
+                    context.ReportError(
+                        error.Path is null ? error.WithPath(path) : error,
+                        resolverContext);
                 }
             }
             else

src/HotChocolate/Core/src/Types/Types/Relay/Serialization/DefaultNodeIdSerializer.cs

@@ -170,7 +170,7 @@ private static unsafe string Format(
 
         Clear(rentedBuffer);
 
-        throw new NodeIdInvalidFormatException(internalId);
+        throw new NodeIdInvalidValueException(s_utf8.GetString(typeName), internalId);
 
         static string FormatBase64(
             ReadOnlySpan<byte> typeName,

src/HotChocolate/Core/src/Types/Types/Relay/Serialization/OptimizedNodeIdSerializer.cs

@@ -433,7 +433,7 @@ public unsafe string Format(object value)
 
             Clear(rentedBuffer);
 
-            throw new NodeIdInvalidFormatException(value);
+            throw new NodeIdInvalidValueException(typeName, value);
         }
 
         private string FormatBase64(Span<byte> span, int written, bool urlSafeBase64, ref byte[]? rentedBuffer, int capacity)

src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_Mutation_NestedDirectiveInput.snap

@@ -8,19 +8,13 @@
           "column": 54
         }
       ],
-      "extensions": {
-        "code": "HC0001",
-        "coordinate": "boom.arg"
-      }
-    },
-    {
-      "message": "Cannot return null for non-nullable field.",
       "path": [
         "nestedObjectOutput",
         "inner"
       ],
       "extensions": {
-        "code": "HC0018"
+        "code": "HC0001",
+        "coordinate": "boom.arg"
       }
     }
   ],

src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_Mutation_WithMutationConventions_NestedDirectiveInput.snap

@@ -8,20 +8,14 @@
           "column": 70
         }
       ],
-      "extensions": {
-        "code": "HC0001",
-        "coordinate": "boom.arg"
-      }
-    },
-    {
-      "message": "Cannot return null for non-nullable field.",
       "path": [
         "nestedObjectOutput",
         "nestedObject",
         "inner"
       ],
       "extensions": {
-        "code": "HC0018"
+        "code": "HC0001",
+        "coordinate": "boom.arg"
       }
     }
   ],

src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_NestedDirectiveInput.snap

@@ -8,19 +8,13 @@
           "column": 46
         }
       ],
-      "extensions": {
-        "code": "HC0001",
-        "coordinate": "boom.arg"
-      }
-    },
-    {
-      "message": "Cannot return null for non-nullable field.",
       "path": [
         "nestedObjectOutput",
         "inner"
       ],
       "extensions": {
-        "code": "HC0018"
+        "code": "HC0001",
+        "coordinate": "boom.arg"
       }
     }
   ],

src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/__snapshots__/TypeConverterTests.Exception_IsAvailableInErrorFilter_WithQueryConventions_NestedDirectiveInput.snap

@@ -8,19 +8,13 @@
           "column": 68
         }
       ],
-      "extensions": {
-        "code": "HC0001",
-        "coordinate": "boom.arg"
-      }
-    },
-    {
-      "message": "Cannot return null for non-nullable field.",
       "path": [
         "nestedObjectOutput",
         "inner"
       ],
       "extensions": {
-        "code": "HC0018"
+        "code": "HC0001",
+        "coordinate": "boom.arg"
       }
     }
   ],

src/HotChocolate/Core/test/Types.Tests/Types/Relay/IdAttributeTests.cs

@@ -461,6 +461,138 @@ public async Task EnsureIdIsOnlyAppliedOnce()
     }
 
     [SuppressMessage("Performance", "CA1822:Mark members as static")]
+    [Fact]
+    public async Task Bare_Id_On_Properties_With_Different_Runtime_Types()
+    {
+        // arrange & act
+        var result =
+            await new ServiceCollection()
+                .AddGraphQLServer()
+                .AddQueryType<ThingQuery>()
+                .AddGlobalObjectIdentification(false)
+                .ExecuteRequestAsync(
+                    OperationRequestBuilder.New()
+                        .SetDocument(
+                            """
+                            {
+                                thing {
+                                    id
+                                    anotherTypeId
+                                }
+                            }
+                            """)
+                        .Build());
+
+        // assert
+        result.ToJson().MatchInlineSnapshot(
+            """
+            {
+              "errors": [
+                {
+                  "message": "The value could not be formatted into an ID for the type `Thing`.",
+                  "path": [
+                    "thing",
+                    "anotherTypeId"
+                  ],
+                  "extensions": {
+                    "originalValue": "26a2dc8f-4dab-408c-88c6-523a0a89a2b5"
+                  }
+                }
+              ],
+              "data": null
+            }
+            """);
+    }
+
+    [Fact]
+    public async Task Invalid_Id_Does_Not_Erase_Sibling_Data()
+    {
+        // arrange & act
+        var result =
+            await new ServiceCollection()
+                .AddGraphQLServer()
+                .AddQueryType<ProbeQuery>()
+                .AddGlobalObjectIdentification(false)
+                .ExecuteRequestAsync(
+                    """
+                    {
+                      byId(id: "invalid")
+                      unrelated
+                    }
+                    """);
+
+        // assert
+        result.ToJson().MatchInlineSnapshot(
+            """
+            {
+              "errors": [
+                {
+                  "message": "The node ID string has an invalid format.",
+                  "path": [
+                    "byId"
+                  ],
+                  "extensions": {
+                    "originalValue": "invalid"
+                  }
+                }
+              ],
+              "data": {
+                "byId": null,
+                "unrelated": "value"
+              }
+            }
+            """);
+    }
+
+    [Fact]
+    public async Task Invalid_Id_On_Skipped_Field_Does_Not_Error()
+    {
+        // arrange & act
+        var result =
+            await new ServiceCollection()
+                .AddGraphQLServer()
+                .AddQueryType<ProbeQuery>()
+                .AddGlobalObjectIdentification(false)
+                .ExecuteRequestAsync(
+                    """
+                    {
+                      byId(id: "invalid") @skip(if: true)
+                      unrelated
+                    }
+                    """);
+
+        // assert
+        result.ToJson().MatchInlineSnapshot(
+            """
+            {
+              "data": {
+                "unrelated": "value"
+              }
+            }
+            """);
+    }
+
+    public class ProbeQuery
+    {
+        public int? GetById([ID] int id) => id;
+
+        public string GetUnrelated() => "value";
+    }
+
+    public class ThingQuery
+    {
+        public Thing GetThing() => new();
+    }
+
+    public class Thing
+    {
+        [ID]
+        public int Id { get; set; } = 1;
+
+        [ID]
+        public Guid AnotherTypeId { get; set; } = new("26a2dc8f-4dab-408c-88c6-523a0a89a2b5");
+    }
+
     public class Query
     {
         public int IntId([ID] int id) => id;