[Fusion] Allow @require intermediates from the requiring schema#9796
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Fusion composition satisfiability validation so @require paths can use intermediate navigation fields from the requiring schema while still requiring leaf values to come from another schema. It also enables the previously skipped circular-requirements audit test.
Changes:
- Distinguishes leaf vs. intermediate fields when computing candidate schemas for requirement validation.
- Re-enables
RequiresCircularas a passing satisfiability validator test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/HotChocolate/Fusion/src/Fusion.Composition/Satisfiability/RequirementsValidator.cs |
Allows intermediate requirement fields to include the excluded schema as a candidate source. |
src/HotChocolate/Fusion/test/Fusion.Composition.Tests/SatisfiabilityValidatorTests.cs |
Unskips the circular @require satisfiability test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 1, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequirementsValidatorto distinguish leaf fields from intermediate (navigation) fields when computing candidate source schemas for a requirement. Leaves still exclude the target schema (the gateway must source their values from elsewhere); intermediates now include all schemas, since the gateway can resolve a navigation step locally in the requiring schema as part of executing the requiring field.RequiresCircular(federation-gateway-auditrequires-circular), which hasPost.byNovicein schema B requiringauthor { yearsOfExperience }wherePost.authoris only declared in B. The previous logic excluded B wholesale and reportedPost.authoras unreachable; the new logic allows the intermediateauthorto come from B (where it's resolved locally) while still requiringyearsOfExperience(the leaf) from outside B.Test plan
dotnet test src/HotChocolate/Fusion/test/Fusion.Composition.Tests --filter "FullyQualifiedName~SatisfiabilityValidatorTests|FullyQualifiedName~RequirementsValidatorTests"— 64 passed, 0 skipped, 0 failed on net8.0, net9.0, and net10.0.HotChocolate.Fusion.Composition.Tests— 498 passed, 0 skipped, 0 failed across all three TFMs.