Fix NRE when ParentRequires targets a composite type#9789
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a null reference exception during operation compilation when ParentRequires targets a composite (object) type by ensuring internal requirement selections for composite fields always include a valid sub-selection.
Changes:
- Update the queryable requirements projection optimizer to emit a minimal
__typenameselection set for composite requirements without explicit sub-selections. - Add an in-memory projections integration test covering
ParentRequireson an object-valued field. - Add an EF Core integration test asserting required navigation projection results in an SQL join (and snapshot the SQL + result).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Data/src/Data/Projections/Optimizers/QueryableRequirementsProjectionOptimizer.cs | Ensures composite requirement selections compile by generating a __typename-only selection set when no sub-selections exist. |
| src/HotChocolate/Data/test/Data.Projections.Tests/IntegrationTests.cs | Adds a regression test for ParentRequires when the required member is an object field. |
| src/HotChocolate/Data/test/Data.Projections.Tests/snapshots/IntegrationTests.Projection_Should_NotThrow_When_ParentRequiresObjectField.snap | Snapshot for the new projections regression test result. |
| src/HotChocolate/Data/test/Data.EntityFramework.Tests/IntegrationTests.cs | Adds an EF Core regression test validating required navigation is projected from SQL (via captured SQL). |
| src/HotChocolate/Data/test/Data.EntityFramework.Tests/snapshots/IntegrationTests.Projection_Should_ProjectRequiredNavigation_When_ParentRequiresObject.md | Snapshot for SQL + execution result (non-NET10). |
| src/HotChocolate/Data/test/Data.EntityFramework.Tests/snapshots/IntegrationTests.Projection_Should_ProjectRequiredNavigation_When_ParentRequiresObject_NET10_0.md | Snapshot for SQL + execution result (NET10-specific). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 1, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9788