Skip to content

Remove npm dist-tag from release.yml #9689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobias-tengler merged 1 commit into from
May 12, 2026
Merged

Remove npm dist-tag from release.yml #9689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,35 +432,26 @@ jobs:
shell: bash
env:
REGISTRY: ${{ vars.NPM_REGISTRY_URL }}
PKG: "@chillicream/nitro-${{ matrix.rid }}"
TARBALL: "./chillicream-nitro-${{ matrix.rid }}-${{ needs.compute-release-context.outputs.git_tag }}.tgz"
run: |
set -euo pipefail

# Pick the band this release publishes under, based on release context.
if [[ "$IS_HIGHEST_STABLE_MAJOR" == "true" ]]; then
PRIMARY_BAND="latest"
SECONDARY_BAND="latest-${MAJOR}"
elif [[ "$IS_STABLE" == "true" ]]; then
PRIMARY_BAND="latest-${MAJOR}"
SECONDARY_BAND=""
elif [[ "$GIT_TAG" =~ -rc\. ]]; then
Comment on lines 439 to 444
PRIMARY_BAND="rc"
SECONDARY_BAND=""
else
PRIMARY_BAND="preview"
SECONDARY_BAND=""
fi

npm publish "$TARBALL" \
--access public \
--registry="$REGISTRY" \
--tag "$PRIMARY_BAND"

if [[ -n "$SECONDARY_BAND" ]]; then
npm dist-tag add "${PKG}@${GIT_TAG}" "$SECONDARY_BAND" --registry="$REGISTRY"
fi

- name: 📤 Upload tarball as artifact
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
Expand Down Expand Up @@ -537,35 +528,26 @@ jobs:
shell: bash
env:
REGISTRY: ${{ vars.NPM_REGISTRY_URL }}
PKG: "@chillicream/nitro"
TARBALL: "./chillicream-nitro-${{ needs.compute-release-context.outputs.git_tag }}.tgz"
run: |
set -euo pipefail

# Pick the band this release publishes under, based on release context.
if [[ "$IS_HIGHEST_STABLE_MAJOR" == "true" ]]; then
PRIMARY_BAND="latest"
SECONDARY_BAND="latest-${MAJOR}"
elif [[ "$IS_STABLE" == "true" ]]; then
PRIMARY_BAND="latest-${MAJOR}"
SECONDARY_BAND=""
elif [[ "$GIT_TAG" =~ -rc\. ]]; then
PRIMARY_BAND="rc"
SECONDARY_BAND=""
else
PRIMARY_BAND="preview"
SECONDARY_BAND=""
fi

npm publish "$TARBALL" \
--access public \
--registry="$REGISTRY" \
--tag "$PRIMARY_BAND"

if [[ -n "$SECONDARY_BAND" ]]; then
npm dist-tag add "${PKG}@${GIT_TAG}" "$SECONDARY_BAND" --registry="$REGISTRY"
fi

- name: 📤 Upload tarball as artifact
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
Expand Down
Loading