[Nitro] Serialize McpAppViewVisibility as camelCase strings#9655
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Nitro MCP tool settings JSON serialization so McpAppViewVisibility values are emitted as camelCase strings (e.g., "model", "app") when using the source-generated System.Text.Json context, and adds tests to validate parsing/formatting/round-tripping behavior.
Changes:
- Register a
System.Text.Jsonenum converter inMcpSettingsSerializerContextto serializeMcpAppViewVisibilityas camelCase strings. - Add snapshot-based tests covering
McpToolSettingsSerializerparse/format behavior, includingvisibility. - Change
McpToolSettingsPermissionsfrom a class to a sealed record.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Nitro/Common/test/ChilliCream.Nitro.Adapters.Mcp.Tests/Serialization/McpToolSettingsSerializerTests.cs | Adds comprehensive parse/format/round-trip tests, including snapshot expectations for camelCase JSON and visibility serialization. |
| src/Nitro/Common/src/ChilliCream.Nitro.Adapters.Mcp/Serialization/McpToolSettings.cs | Adjusts McpToolSettingsPermissions type definition (class → sealed record). |
| src/Nitro/Common/src/ChilliCream.Nitro.Adapters.Mcp/Serialization/McpSettingsSerializerContext.cs | Registers a custom enum converter in the source-gen context to camelCase McpAppViewVisibility values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 13, 2026
Closed
This was referenced May 21, 2026
This was referenced May 30, 2026
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.