Repository navigation
[Fusion] Fix oversized path pool slot storage - #10557
Merged
Merged
Conversation
Contributor
Patch coverage97.3% of changed lines covered (72/74)
Uncovered changed lines (JSON){
"sha": "4f395554c1e967e6b21885dfdfc4b5361195bdf8",
"files": [
{ "path": "src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/PathSegmentPool.cs", "ranges": [[352, 352], [407, 407]] }
]
}Project coverage: 59.0% (311476/527757 lines) |
tobias-tengler
marked this pull request as ready for review
October 17, 2026 21:01
This was referenced Oct 25, 2026
Merged
This was referenced Nov 1, 2026
This was referenced Nov 1, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 21 updates
DFE-Digital/SUI_Matcher#424
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fusion reserves a 13.6-million-entry reference table for its shared path-segment pool, allocating about 104 MiB even when only the initial 4,096 slots are needed.
This change allocates reference pages on demand, reducing initial allocation to about 58 KiB while preserving the batching and local reuse from #10548. Trim releases segment arrays and keeps the reference pages for reuse. After the tested 131,072-array peak, about 1 MiB of reference pages remains reserved.
mainmainmain