Repository navigation
[Fusion] Fix tests failing on machines with one or two processors - #10544
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
One or more issues must be addressed before approval.
1 open finding
What changed in this PR
This PR makes Fusion’s automatic test IDs deterministic across processor counts and resolver execution order.
Changes:
- Generates IDs from parent IDs, response names, arguments, and list indexes.
- Adds deterministic-ID coverage tests.
- Regenerates affected snapshots and expected IDs.
| File | Description |
|---|---|
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/TransportErrorTests.Resolve_Sequence_Second_Service_Offline_SubField_Nullable_Parent_Nullable.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/TransportErrorTests.Resolve_Sequence_Second_Service_Offline_SubField_NonNull_Parent_Nullable.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/TransportErrorTests.Resolve_Sequence_Second_Service_Offline_SubField_NonNull_Parent_NonNull.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/TransportErrorTests.Resolve_Parallel_One_Service_Offline_EntryFields_Nullable.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/SubgraphErrorTests.Resolve_Sequence_SubField_Nullable_Parent_Nullable_One_Service_Errors_SubField.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/SubgraphErrorTests.Resolve_Sequence_SubField_Nullable_Parent_Nullable_One_Service_Errors_EntryField.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/SubgraphErrorTests.Resolve_Sequence_SubField_NonNull_Parent_Nullable_One_Service_Errors_SubField.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/SubgraphErrorTests.Resolve_Sequence_SubField_NonNull_Parent_Nullable_One_Service_Errors_EntryField.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/SubgraphErrorTests.Resolve_Sequence_SubField_NonNull_Parent_NonNull_One_Service_Errors_SubField.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/SubgraphErrorTests.Resolve_Sequence_SubField_NonNull_Parent_NonNull_One_Service_Errors_EntryField.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Viewer_Bug_3.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Viewer_Bug_2.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Unresolvable_Subgraph_Is_Not_Chosen_If_Data_Is_Available_In_Resolvable_Subgraph.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Subgraph_Containing_More_Selections_Is_Chosen.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Same_Selection_On_Two_Object_Types_That_Require_Data_From_Another_Subgraph.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.GetFirstPage_With_After_Null.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Field_Below_Shared_Field_Only_Available_On_One_Subgraph_Type_Of_Shared_Field_Not_Node.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Field_Below_Shared_Field_Only_Available_On_One_Subgraph_Type_Of_Shared_Field_Not_Node_3.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Field_Below_Shared_Field_Only_Available_On_One_Subgraph_Type_Of_Shared_Field_Not_Node_2.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Fetch_User_With_Node_Field_From_Two_Subgraphs.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Authors_And_Reviews_AutoCompose.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Authors_And_Reviews_And_Products_With_Variables.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Authors_And_Reviews_And_Products_Query_TypeName.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/v15/__snapshots__/DemoIntegrationTests.Authors_And_Reviews_And_Products_AutoCompose.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/InterfaceObjectRequiresTests.cs | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/GlobalObjectIdentificationTests.cs | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/AbstractTypeTests.cs | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Union_Sibling_Lookup_Partially_Skipped_Nested_Lookup_Still_Issued_When_Other_Branch_Fails.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Union_List_Concrete_Type_Selections_Have_Same_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Union_List_Concrete_Type_Selections_Have_Dependency_To_Same_Subgraph.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Union_List_Concrete_Type_Selection_Has_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Union_List_Concrete_Type_Has_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Union_Field_Concrete_Type_Selections_Have_Same_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Union_Field_Concrete_Type_Selections_Have_Dependency_To_Same_Subgraph.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Union_Field_Concrete_Type_Selection_Has_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Union_Field_Concrete_Type_Has_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Object_List_Union_Field_Concrete_Type_Selections_Have_Same_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Object_List_Union_Field_Concrete_Type_Selections_Have_Dependency_To_Same_Subgraph.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Object_List_Union_Field_Concrete_Type_Selection_Has_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/UnionTests.Object_List_Union_Field_Concrete_Type_Has_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/SharedPathErrorPocketingTests.Entity_Interface_With_Shared_Value_Type_Under_Inline_Fragment_Pockets_Error.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/RequireTests.Requirement_On_Property_Within_Nullable_Object.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ProvidesTests.Provides_Simple_Covers_Selection.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ProvidesTests.Provides_Partial_Covers_Some.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ProvidesTests.Provides_External_Without_Cover.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ProvidesTests.Provides_Deeply_Nested_Chain.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ProvidesTests.Planner_Should_Route_To_Owning_Source_When_Local_Field_Is_Orphan_External.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/MutationTests.Mutation_Root_With_Batched_Node_Lookups_Executes_Followups.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.List_Field_Interface_Object_Property_Linked_Field_With_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.List_Field_Interface_Object_Property_Linked_Field_With_Dependency_Same_Selection_In_Concrete_Type.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.List_Field_Interface_Object_Property_Concrete_Type.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.List_Field_Interface_Object_Property_Concrete_Type_With_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.Interface_List_Field_Concrete_Type.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.Interface_List_Field_Concrete_Type_With_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.Interface_List_Field_Concrete_Type_Linked_Field_With_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.Interface_Field_With_Type_Refinements_Exclusive_To_Other_Schema.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.Interface_Field_With_Only_Type_Refinements_On_Same_Schema.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.Interface_Field_Linked_Field_With_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.Interface_Field_Linked_Field_With_Dependency_Same_Selection_In_Concrete_Type.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.Interface_Field_Linked_Field_With_Dependency_Different_Selection_In_Concrete_Type.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.Interface_Field_Concrete_Type.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.Interface_Field_Concrete_Type_With_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceTests.Interface_Field_Concrete_Type_Linked_Field_With_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceObjectTests.Opaque_TypeName_Is_Recovered_Through_Covering_Lookup.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceObjectTests.Id_Only_Selection_Is_A_Single_Fetch.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceObjectTests.Fragment_Narrowing_Resolves_StandIn_Field_Through_Covering_Lookup.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceObjectTests.Fragment_Narrowing_Resolves_ConcreteOwned_Field_From_Opaque_Root.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceObjectTests.Fragment_Narrowing_Resolves_Concrete_Fields_Through_Covering_Lookup.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceObjectTests.Default_Field_Inheritance_Resolves_From_StandIn_Only.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceObjectRequiresTests.AnotherUsers_SelectsUserAge.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceObjectNestedTests.Playlist_Media_ResolvesConcreteFieldThroughInterfaceObject.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/InterfaceInheritanceExecutionTests.Execution_Should_ResolveUnionMemberField_When_LookupNarrowsSourcePathByTypeCondition.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/GlobalObjectIdentificationTests.Node_Field_Two_Concrete_Types_Selections_Have_Same_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/GlobalObjectIdentificationTests.Node_Field_Two_Concrete_Types_Selections_Have_Different_Dependencies.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/GlobalObjectIdentificationTests.Node_Field_Selections_On_Interface_Selection_Has_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/GlobalObjectIdentificationTests.Node_Field_Selections_On_Interface_And_Concrete_Type_Both_Have_Same_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/GlobalObjectIdentificationTests.Node_Field_Interface_Selection_With_Nested_Field_From_Other_Subgraph.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/GlobalObjectIdentificationTests.Node_Field_Concrete_Type_Selection_Has_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/GlobalObjectIdentificationTests.Node_Entry_With_Required_Field_And_Nested_Lookup.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/GlobalObjectIdentificationTests.Node_Entry_Should_Resolve_When_Required_Field_Is_In_Conditional_Fragment.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_With_Forwarded_Variable_Merges_Into_Subgraph_Request.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_With_Error_In_Deferred_Fragment_Should_Return_Error_In_Incremental_Payload.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_Two_Siblings_With_Overlapping_Fields_Should_Deduplicate.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_Two_Siblings_Sharing_Field_Emit_One_Incremental_That_Completes_Both_Groups.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_Should_SuppressDescendantPatch_When_NullMarkerBubblesAbovePendingPath.snap | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_Should_NotEmitDescendantData_When_InaccessibleRuntimeTypeNullsPendingAncestor.snap | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_Should_EmitSingleNullPatch_When_InaccessibleRuntimeTypeNullsPendingList.snap | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_RootFragment_Should_DeliverDeferredFetch_When_RootSelectsOnlyTypename.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_RootFragment_Should_DeliverDeferredFetch_When_RootSelectsNothingElse.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_On_Mutation_Result_Should_Return_Incremental_Response.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_Nested_Without_Label_On_Inner_Should_Return_Incremental_Response.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_Nested_Should_Return_Incremental_Response_In_Order.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_Nested_Composite_On_One_Of_Sibling_Type_Conditions.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_Nested_Composite_On_Both_Sibling_Type_Conditions.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_KeyOnlyField_Should_Return_NonStreamed_Result.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_KeyOnlyField_Should_KeepTypename_When_TypenameInsideDefer.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_KeyOnlyField_Should_KeepTypename_When_ClientSelectsTypenameSibling.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/DeferTests.Defer_IfFalse_Variable_Should_Return_NonStreamed_Result.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/CostEnforcementTests.OverCostRequest_Should_Execute_When_RequestCostOptionsRaiseTypeCostLimit.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/CostEnforcementTests.OverCostRequest_Should_Execute_When_DefaultSecurityIsDisabled.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ConditionalTests.NodeField_Skip_On_Interface_Selection_Type_Refinement_With_Same_Unskipped_Selection.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ConditionalTests.Lookup_Skip_Only_On_Some_Fields_Fetched_Through_Lookup.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ConditionalTests.Lookup_Skip_On_Parent_Field_Of_Field_Fetched_Through_Lookup.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ConditionalTests.Lookup_Skip_On_Field_With_Requirement.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ConditionalTests.Lookup_Skip_On_Field_Fetched_Through_Lookup.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ConditionalTests.Lookup_Skip_Not_Only_On_Field_With_Requirement.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ConditionalTests.Lookup_Skip_Around_Fields_Fetched_Through_Lookup.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ConditionalTests.Lookup_Multiple_Skip_Levels_Around_Fields_Fetched_Through_Lookup.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ConditionalTests.Lookup_Multiple_Skip_Levels_Around_Fields_Fetched_Through_Lookup_And_On_Same_Source_Schema.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ConditionalTests.Interface_Field_With_Type_Refinement_Under_Skip.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/ConditionalTests.Interface_Field_With_Type_Refinement_Under_Nested_Skip.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/AbstractTypeTests.Union_Field_With_Type_Refinements_And_Union_Lookup.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/AbstractTypeTests.Union_Field_With_Type_Refinements_And_Union_Lookup_With_Additional_Concrete_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/AbstractTypeTests.Union_Field_With_Type_Refinements_And_Concrete_Lookups.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/AbstractTypeTests.Union_Field_With_Type_Refinements_And_Concrete_Lookups_With_Additional_Concrete_Dependency.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/AbstractTypeTests.Interface_Field_Without_Type_Refinements_With_Interface_Lookup.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/AbstractTypeTests.Interface_Field_Without_Type_Refinements_With_Interface_Lookup_And_Field_From_Specific_Source.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/AbstractTypeTests.Interface_Field_Without_Type_Refinements_With_Concrete_Lookups.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/AbstractTypeTests.Interface_Field_Without_Type_Refinements_With_Concrete_Lookups_And_Field_From_Specific_Source.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/AbstractTypeTests.Interface_Field_With_And_Without_Type_Refinements_Type_Refinements_Do_Not_Match.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/AbstractTypeTests.Interface_Field_With_And_Without_Type_Refinements_All_Fields_On_Dedicated_Schemas.yaml | Updated as part of this pull request. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/__snapshots__/AbstractTypeTests.Interface_Field_With_And_Without_Type_Refinements_Aliased_With_Different_Selections.yaml | Updated as part of this pull request. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tobias-tengler
approved these changes
Oct 14, 2026
This was referenced Oct 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProcessorCount * 2), soFusion.AspNetCore.Testssnapshots failed on machines with one or two processors: 27 tests at one processor, one at two.<TypeName>:<number>), and IDs passed as lookup arguments are still used as given. Starting from the parent's ID keeps an object's IDs the same however the gateway batches its lookups.DemoIntegrationTests.Authors_And_Reviews_Query_ReviewsUserthe client response is identical after masking, and the batchednoderequest to the accounts schema now carries 15 variable sets instead of 12: counter values used to repeat across source schema requests, so the gateway deduplicated keys that belonged to different users. Five tests that assert mock IDs in code were updated to the new values.Test plan
Fusion.AspNetCore.Testson net11.0 withDOTNET_PROCESSOR_COUNTset to 1, 2, and 3, and unset: 0 failures in each run.Fusion.Tests.Sharedon net11.0: all 68 tests pass, including new tests for selection order, variable batches, and argument values given as literals and as variables. CI's test matrix does not include this project, so it was run locally.