Repository navigation
Fix the HTTP QUERY activity test failing on .NET 9 - #10434
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Updates the HTTP QUERY activity test to handle .NET 9-specific OpenTelemetry output.
Changes:
- Adds a dedicated .NET 9 snapshot selection.
- Records .NET 9’s
_OTHERmethod tags and span name. - Preserves existing snapshots for other frameworks.
| File | Description |
|---|---|
src/HotChocolate/Diagnostics/test/Diagnostics.Tests/ActivityServerDiagnosticListenerTests.cs |
Selects the dedicated .NET 9 snapshot. |
src/HotChocolate/Diagnostics/test/Diagnostics.Tests/__snapshots__/ActivityServerDiagnosticListenerTests.Http_Query_SingleRequest_GetHeroName_NET9_0.snap |
Adds expected .NET 9 activity output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 25, 2026
Merged
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Http_Query_SingleRequest_GetHeroNamefailed on net9.0.OpenTelemetry.Instrumentation.AspNetCoreleavesQUERYout of its known HTTP methods when running on .NET 9 (open-telemetry/opentelemetry-dotnet-contrib#3969), so the server span there reportshttp.request.methodas_OTHER, addshttp.request.method_original: QUERY, and is namedHTTP /graphql/{**slug}. CI runs tests on net11.0 only, so this did not show up there.NET9_0snapshot. net8.0 and net10.0 keep sharing the default snapshot, and net11.0 keeps its own.Test plan
ActivityServerDiagnosticListenerTestspasses on net8.0, net9.0, and net10.0. The net11.0 postfix and snapshot are unchanged.NET9_0snapshot differs from the default one only in the span name and the two method tags.