Repository navigation
Enable variable batching by default - #10405
Merged
Merged
Conversation
github-actions
Bot
added
📚 documentation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Resolve conflicting documented defaults and align the new test name with repository conventions.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Enables variable batching by default while keeping request batching opt-in.
Changes:
- Updates server defaults and transport capability tests.
- Revises batching and migration documentation.
- Adds Fusion coverage for default variable batching.
File summaries
| File | Summary |
|---|---|
website/content/docs/hotchocolate/server/index.md |
Updates batching overview. |
website/content/docs/hotchocolate/server/batching.md |
Documents new defaults. |
website/content/docs/hotchocolate/migrating/migrate-from-15-to-16.md |
Updates migration guidance. |
website/content/docs/fusion/migration/migrate-from-15-to-16.md |
Updates Fusion migration guidance. |
src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/VariableBatchingTests.cs |
Tests default variable batching. |
src/HotChocolate/AspNetCore/test/AspNetCore.Tests/TransportCapabilitiesProviderTests.cs |
Tests batching capability defaults. |
src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Options/GraphQLServerOptions.cs |
Enables variable batching by default. |
Review details
Suppressed comments (1)
src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/VariableBatchingTests.cs:12
- The new test name does not follow the repository's
Method_Should_Outcome_When_Conditionnaming convention and is harder to parse becauseProduceAResultPerVariableSetruns the words together. Use underscore-separated words consistently with the surrounding tests.
public async Task Execute_Should_ProduceAResultPerVariableSet_When_ServerOptionsAreDefault()
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # Enabling Batching | ||
|
|
||
| Batching is disabled by default as a security measure. You enable the types of batching you want to allow through the `AllowedBatching` flags enum using `ModifyServerOptions`: | ||
| Variable batching is enabled by default. Request batching is disabled by default. You configure the allowed types through the `AllowedBatching` flags enum using `ModifyServerOptions`. To disable all batching: |
Contributor
Patch coverage100.0% of changed lines covered (1/1)
Project coverage: 58.0% (288973/498393 lines) |
This was referenced Oct 25, 2026
Merged
This was referenced Nov 1, 2026
This was referenced Nov 1, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 21 updates
DFE-Digital/SUI_Matcher#424
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.