Repository navigation
Add Fusion executor and serialization micro benchmarks - #10242
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new Fusion execution/serialization micro-benchmarks and updates existing Fusion benchmarks to match the updated OperationCompiler.Compile(id, hash, shortHash, operationDefinition) signature, keeping benchmark harnesses compiling and comparable.
Changes:
- Added new micro-benchmarks targeting MetaDb sequential reader cursor navigation, null-leaf merge fast paths, and executor wakeup dispatch behavior.
- Updated multiple benchmarks to pass
id,hash, andshortHashintoOperationCompiler.Compile. - Updated Fusion
OperationRequestbenchmark setup to pass UTF-8 query bytes (ReadOnlyMemory<byte>) instead ofstring.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/VariableMergingBenchmark.cs | Updates OperationCompiler.Compile call to include shortHash. |
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/SequentialReaderPackedCursorBenchmark.cs | Adds benchmark for sequential reader navigation, comparing packed-cursor vs product reader. |
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/SelectionTypeShapeBenchmark.cs | Updates OperationCompiler.Compile call to include shortHash. |
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/SelectionChildMapBenchmark.cs | Updates OperationCompiler.Compile call to include shortHash. |
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/NullLeafFastPathBenchmark.cs | Adds benchmark for null-valued property merge behavior and candidate fast path. |
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/GraphQLQueryBenchmark.cs | Switches Fusion OperationRequest query argument to UTF-8 bytes. |
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/CompositeObjectCreateTemplateBenchmark.cs | Updates OperationCompiler.Compile call to include shortHash. |
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/CompositeContextFusedDecodeBenchmark.cs | Updates OperationCompiler.Compile call to include shortHash. |
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/AsyncAutoResetEventDispatchBenchmark.cs | Adds benchmark comparing current vs unsafe-dispatch candidate for executor wakeups. |
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/AbstractSelectionSetCacheBenchmark.cs | Updates OperationCompiler.Compile call to include shortHash. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| continue; | ||
| } | ||
|
|
||
| states.Add($"{property.Name}:{resultField.ValueKind}"); |
Comment on lines
+314
to
+318
| Consumed += MergeBaseline(element); | ||
| var baselineStates = CaptureSlotStates(element); | ||
|
|
||
| Consumed += MergeWithNullFastPath(element); | ||
| var fastPathStates = CaptureSlotStates(element); |
The equivalence check merged both kernels into the same target object, so a kernel that silently skipped a write could still observe the value written by the other one. Each kernel now writes into its own pristine composite document fed from its own source document, and the captured slot state includes the raw JSON text of scalar slots, matching what the check claims to compare.
This was referenced Aug 29, 2026
Merged
This was referenced Sep 18, 2026
Closed
Closed
Closed
This was referenced Sep 28, 2026
This was referenced Oct 5, 2026
Merged
This was referenced Oct 19, 2026
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.