Repository navigation
Deflake prepared operation cache eviction test - #10159
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Deflakes PreparedOperationCacheTests by replacing a blocking wait for async executor eviction with an awaited, cancellation-aware completion signal, improving reliability on slower CI runners.
Changes:
- Replaced
ManualResetEventSlim+ shortCancellationTokenSourcewith aTaskCompletionSourceusingRunContinuationsAsynchronously. - Switched cancellation to
TestContext.Current.CancellationTokenand added an explicit 30sWaitAsynctimeout cap.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Aug 6, 2026
Merged
This was referenced Aug 13, 2026
Closed
Closed
This was referenced Aug 25, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operation_Cache_Should_Be_Scoped_To_Executorwaited for theEvictedevent by blocking the test thread onManualResetEventSlim.Waitunder a 5-secondCancellationTokenSource. Eviction is asynchronous (a channel write that triggers a full schema rebuild and warmup), so on a loaded CI runner the wait exceeded its budget and the test failed withOperationCanceledException.TaskCompletionSource(RunContinuationsAsynchronously), keeps no thread blocked while the rebuild runs, and takes its token fromTestContext.Current.CancellationToken, matching the sibling test. A 30-secondWaitAsynccap remains so a genuinely lost event surfaces as a timeout instead of a hang.Test plan
dotnet test src/HotChocolate/Core/test/Execution.Tests --filter-class '*PreparedOperationCacheTests*': 8/8 pass across net8.0, net9.0, net10.0, and net11.0.