fix(query): fixed results to mention correct resource type in secret without expiration date query

[cx-ricardo-jesus]

Reason for Proposed Changes

• Currently, the query Secret Without Expiration Date returns a misleading result, stating that a resource of type Microsoft.Security/securityContacts should have attributes.exp property id defined, but the resource that this query is tackling is actually Microsoft.KeyVault/vaults/secrets

Proposed Changes

• Changed the keyActualValue and keyExpectedValue to mention resources of type Microsoft.KeuVault/vaults/secrets.
• Simplified the query to have only one policy. The query does the same verifications as before.
• After changing the go version, the gosec linter returns a warning G602: slice index out of range.
• To fix this warning, a guard condition was added inside the getKeyWithCurlyBrackets method, by adding a condition len(parts) >= valuePartsLength before accessing parts[len(parts)-2] and parts[len(parts)-1] to prevent potential index out of bounds errors

I submit this contribution under the Apache-2.0 license.

[github-actions]

KICS version: v2.1.18

Category Results CRITICAL 0 HIGH 0 MEDIUM 0 LOW 0 INFO 0 TRACE 0 TOTAL 0	Metric Values Files scanned 1 Files parsed 1 Files failed to scan 0 Total executed queries 47 Queries failed to execute 0 Execution time 0

[cx-artur-ribeiro]

LGTM!

[cx-artur-ribeiro]

LGTM