Skip to content

fix(queries): fixed results on queries that had unhandled %s#7950

Merged
cx-ricardo-jesus merged 10 commits into
masterfrom
AST-130062
Jan 30, 2026
Merged

fix(queries): fixed results on queries that had unhandled %s#7950
cx-ricardo-jesus merged 10 commits into
masterfrom
AST-130062

Conversation

@cx-ricardo-jesus

@cx-ricardo-jesus cx-ricardo-jesus commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Closes #

Reason for Proposed Changes

  • Currently, some queries are not handling %s with sprintf functions.

Proposed Changes

  • Query Website Azure Active Directory Disabled for AzureResourceManager:
    • simplified the query to have just one policy.
    • added one positive test, positive7.tf, which covers the cases when the field identity.type is defined to UserAssigned without the field identity.userAssignedIdentities defined.
    • removed unnecessary %s.
  • Query API Gateway With Invalid Compression for CloudFormation/AWS:
    • simplified query to have just one policy.
    • added sprintf to handle %s.
  • Query ALB Listening on HTTP for Alicloud:
    • added sprintf to handle %s.
  • Query API Gateway Access Logging Disabled for Terraform/AWS:
    • added sprintf to handle %s.
  • Query Serverless API Without Content Encoding for Cloudformation/AWS_SAM:
    • added sprintf to handle %s.
    • simplified query to have just one policy.

I submit this contribution under the Apache-2.0 license.

@cx-ricardo-jesus cx-ricardo-jesus requested a review from a team as a code owner January 20, 2026 16:10
@cx-ricardo-jesus cx-ricardo-jesus marked this pull request as draft January 20, 2026 16:11
@github-actions github-actions Bot added the query New query feature label Jan 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.18

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-ricardo-jesus cx-ricardo-jesus marked this pull request as ready for review January 21, 2026 12:35
@github-actions github-actions Bot added cloudformation CloudFormation query alicloud terraform Terraform query azure PR related with Azure Cloud aws PR related with AWS Cloud labels Jan 21, 2026

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job Ricardo.

@cx-ricardo-jesus cx-ricardo-jesus merged commit 80ea470 into master Jan 30, 2026
28 checks passed
@cx-ricardo-jesus cx-ricardo-jesus deleted the AST-130062 branch January 30, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alicloud aws PR related with AWS Cloud azure PR related with Azure Cloud cloudformation CloudFormation query query New query feature terraform Terraform query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants