fix(query): directly covered the cases where vhd_containers is defined on the azurerm_virtual_machine_scale_set_resource#7923
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Closes #
Reason for Proposed Changes
"Beta - VM Without Managed Disk"supports the cases when the fieldvhd_containersis defined inside thestorage_profile_os_diskblock, but in reality it flags these cases because the fieldmanaged_disk_type, which, according to the azurerm_virtual_machine_scale_set Terraform resource documentation the field mentioned before cannot be both defined insidere the resource.azurerm_virtual_machinethat supports unmanaged disks. The support for this resource type wasn't added because the support for the resource of typeazurerm_virtual_machinewas already on the query.Proposed Changes
get_resultsthat checks if the fieldvhd_containersis defined inside thestorage__profile_os_disk.I submit this contribution under the Apache-2.0 license.