feat(query): new query that ensures that container instances are using private virtual networks for terraform/azure#7877
Merged
Merged
Conversation
…g private virtual networks
…g private virtual networks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Reason for Proposed Changes
Proposed Changes
ip_address_typefield is defined toPrivate. Another field that could be relevant in this scenario is checking if the fieldsubnet_idis defined. However, according to the documentation, if the fieldip_address_typeis defined asPrivate, the fieldsubnet_idmust also be defined. Defining the fieldip_address_typetoPrivateand not defining the fieldsubnet_idwill result in an error, as seen below, so it is only necessary to check if the fieldip_address_typeis defined toPrivate.get_res. The helper functionget_reschecks if the fieldip_address_typeis not defined or set toPrivate, resulting in a positive result if either of these scenarios occurs.I submit this contribution under the Apache-2.0 license.