feat(query): implements "Beta - SQL DB Instance With Exposed Trace Logs"

[cx-andre-pereira]

Reason for Proposed Changes

• Currently there is no query to ensure that a "google_sql_database_instance" resource with a "SQLSERVER" based "database_version" has the '3625'(trace log) flag set to "on".

• Quoting CIS_Google_Cloud_Platform_Foundation_Benchmark_v4.0.0 page 259: "3625(trace log) Limits the amount of information returned to users who are not members of the sysadmin fixed server role, by masking the parameters of some error messages using '******'. Setting this in a Google Cloud flag for the instance allows for security through obscurity and prevents the disclosure of sensitive information, hence this is recommended to set this flag globally to on to prevent the flag having been left off, or changed by bad actors.

Proposed Changes

• Implemented the missing query.

• The query will flag for 4 separate instances : (all after ensuring "database_version" is SQLSERVER based (possible values list))

  • Missing the "settings" field
  • Missing the "settings.database_flags" field
  • Missing a definition for the "3625" flag on the "database_flags" field
  • Setting the "3625" flag to a value that is not "on" (default value is off)

Tenable reference

I submit this contribution under the Apache-2.0 license.

[github-actions]

KICS version: v2.1.13

Category Results CRITICAL 0 HIGH 0 MEDIUM 0 LOW 0 INFO 0 TRACE 0 TOTAL 0	Metric Values Files scanned 1 Files parsed 1 Files failed to scan 0 Total executed queries 47 Queries failed to execute 0 Execution time 0

[cx-artur-ribeiro]

Only a quality of life change, the rest looks good to me!

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
21271469	Triggered	Generic Password	8dc4bcb	assets/queries/terraform/azure/unrestricted_sql_server_access/test/positive3.tf	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}