Skip to content

fix(typeflag): fix bicep wrong behavior with type and excludeType flags#7765

Merged
cx-artur-ribeiro merged 3 commits into
masterfrom
fix-bicep-type-flag-behavior
Oct 14, 2025
Merged

fix(typeflag): fix bicep wrong behavior with type and excludeType flags#7765
cx-artur-ribeiro merged 3 commits into
masterfrom
fix-bicep-type-flag-behavior

Conversation

@cx-artur-ribeiro

@cx-artur-ribeiro cx-artur-ribeiro commented Oct 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reason for Proposed Changes

  • Since Bicep is a file extension associated with Azure Resource Manager (ARM) and not a separate platform, we should allow the use of the flags -t, --type or --exclude-type with azureResourceManager to include or exclude both ARM and Bicep files.

Proposed Changes

  • Rename type name from bicep to arm;
  • Add unit tests coverage to the intended behaviour.

I submit this contribution under the Apache-2.0 license.

@cx-artur-ribeiro cx-artur-ribeiro self-assigned this Oct 12, 2025
@github-actions

github-actions Bot commented Oct 12, 2025

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.13

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@github-actions github-actions Bot added arm Azure Resource Manager query azure PR related with Azure Cloud labels Oct 12, 2025
@cx-artur-ribeiro cx-artur-ribeiro marked this pull request as ready for review October 12, 2025 12:03
@cx-artur-ribeiro cx-artur-ribeiro requested a review from a team as a code owner October 12, 2025 12:03
cx-rui-araujo
cx-rui-araujo suggested changes Oct 13, 2025
View reviewed changes

@cx-rui-araujo cx-rui-araujo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cx-artur-ribeiro please check my comment

Comment thread pkg/analyzer/analyzer_test.go
cx-rui-araujo
cx-rui-araujo approved these changes Oct 14, 2025
View reviewed changes

@cx-rui-araujo cx-rui-araujo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-artur-ribeiro cx-artur-ribeiro merged commit 1fa6617 into master Oct 14, 2025
26 checks passed
@cx-artur-ribeiro cx-artur-ribeiro deleted the fix-bicep-type-flag-behavior branch October 14, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cx-rui-araujo cx-rui-araujo cx-rui-araujo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cx-artur-ribeiro cx-artur-ribeiro

Labels

arm Azure Resource Manager query azure PR related with Azure Cloud

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cx-artur-ribeiro @cx-rui-araujo