fix(query): removed unnecessary else on get_children helper function from sql server database with unrecommended retention days query

[cx-ricardo-jesus]

Closes #

Reason for Proposed Changes

• On the current implementation, the helper function get_children does not use the second else case on any scenario:

get_children(doc, parent, path) = childArr { 
	common_lib.valid_key(parent, "resources")
    childArr := [{"value": parent.resources, "path": array.concat(path, ["resources"])}]
} else = childArr { 
    not common_lib.valid_key(parent, "resources")
    not common_lib.valid_key(parent, "dependsOn")
	values := [x |
    	[path_child, value_child] := walk(doc)
        value_child.name != parent.name
        not common_lib.valid_key(value_child, "dependsOn")
		startswith(value_child.name, parent.name)
        x := {"value": [value_child], "path": path_child}
    ]
	count(values) > 0
    unique := {y | y := values[_]} 
    childArr := [y | y := unique[_]]
} else = childArr {
	not common_lib.valid_key(parent, "resources")
	values := [x | 
		[path_child, value_child] := walk(doc)
		value_child.name != parent.name
		common_lib.valid_key(value_child, "dependsOn")
		d := value_child.dependsOn[_]
		search_values := {"type": parent.type, "name": parent.name}
		contains(d, search_values.type)
		contains(d, search_values.name)
		x := {"value": [value_child], "path": path_child}
	]
	count(values) > 0
	unique := {y | y := values[_]}
	childArr := [y | y := unique[_]]
}

Proposed Changes

• Removed the second else from the helper function and added an get_searchLine helper function in order to obtain the correct value for the searchLine.
• Added one negative case on the test cases (negative4.bicep and negative4.json), when the state from the auditingSetting is not enabled.
• Added one positive case on the test cases (positive7.bicep and positive7.json) that do not have the keyword dependsOn, the refer to a parent resource.

I submit this contribution under the Apache-2.0 license.

[github-actions]

KICS version: v2.1.11

Category Results CRITICAL 0 HIGH 0 MEDIUM 0 LOW 0 INFO 0 TRACE 0 TOTAL 0	Metric Values Files scanned 1 Files parsed 1 Files failed to scan 0 Total executed queries 47 Queries failed to execute 0 Execution time 0

[cx-artur-ribeiro]

LGTM