Skip to content

fix(query): added suport for modules and more test samples for tags not copied to rds cluster snapshot query for terraform#7691

Merged
cx-andre-pereira merged 21 commits into
masterfrom
AST-40743
Sep 9, 2025
Merged

fix(query): added suport for modules and more test samples for tags not copied to rds cluster snapshot query for terraform#7691
cx-andre-pereira merged 21 commits into
masterfrom
AST-40743

Conversation

@cx-ricardo-jesus

Copy link
Copy Markdown
Contributor

Closes #

Reason for Proposed Changes

  • The current query implementation does not support RDS modules.

Proposed Changes

  • The query now has two policies, the first one handles the resources aws_rds_cluster and aws_db_instance, and the second policy handles the equivalent modules.
  • For each one of the policies, I used the helper function tags_not_copied_to_snapshot the check the cases when the field copy_tags_to_snapshot is undefined or defined to false and returns the respective result.
  • Added extra test cases have the modules.

I submit this contribution under the Apache-2.0 license.

@cx-ricardo-jesus cx-ricardo-jesus requested a review from a team as a code owner September 2, 2025 16:28
@gitguardian

gitguardian Bot commented Sep 2, 2025

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
4266022 Triggered Generic Password 7fedc1b assets/queries/cloudFormation/aws/amplify_branch_basic_auth_config_password_exposed/test/negative7.yaml View secret
9419039 Triggered Username Password 7fedc1b assets/queries/cloudFormation/aws/amplify_branch_basic_auth_config_password_exposed/test/positive5.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions github-actions Bot added query New query feature terraform Terraform query aws PR related with AWS Cloud labels Sep 2, 2025
@github-actions

github-actions Bot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.11

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-andre-pereira cx-andre-pereira merged commit da49b58 into master Sep 9, 2025
26 of 27 checks passed
@cx-andre-pereira cx-andre-pereira deleted the AST-40743 branch September 9, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws PR related with AWS Cloud query New query feature terraform Terraform query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants