Skip to content

fix(query): fixed searchLine and added new test case for web app not using tls last version query for azureResourceManager#7690

Merged
cx-andre-pereira merged 8 commits into
masterfrom
AST-108415--new-test-case-and-fixed-search-line
Sep 9, 2025
Merged

fix(query): fixed searchLine and added new test case for web app not using tls last version query for azureResourceManager#7690
cx-andre-pereira merged 8 commits into
masterfrom
AST-108415--new-test-case-and-fixed-search-line

Conversation

@cx-ricardo-jesus

Copy link
Copy Markdown
Contributor

Closes #

Reason for Proposed Changes

  • The current query implementation has the searchLine pointing to the resource name, which could be improved by pointing to the field of the vulnerability itself.
  • Also, the case when the block siteConfig is defined without a minTlsVersion defined was not covered by the test cases.

Proposed Changes

  • Changed the sl return value on the prepare_issue helper function.
  • Added the missing case(positive4.json and positive4.bicep)

I submit this contribution under the Apache-2.0 license.

@cx-ricardo-jesus cx-ricardo-jesus requested a review from a team as a code owner September 2, 2025 15:19
@github-actions github-actions Bot added the query New query feature label Sep 2, 2025
@github-actions

github-actions Bot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.11

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-andre-pereira cx-andre-pereira merged commit ff4e6d9 into master Sep 9, 2025
27 checks passed
@cx-andre-pereira cx-andre-pereira deleted the AST-108415--new-test-case-and-fixed-search-line branch September 9, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

query New query feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants