fix(test): changed iam_database_authentication_field value from true to false on the sample negative5.tf#7677
Merged
Merged
Conversation
…us complete boolean logic update
…_Update--cloudformation/aws
…dformation/aws' of https://github.com/cx-andre-pereira/kics into AST-40783--FN_CloudFormation_Boolean_Logic_Update--cloudformation/aws
…_Update--cloudformation/aws
…_Update--cloudformation/aws
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 19562607 | Triggered | Generic Password | 5cbea1a | assets/queries/common/passwords_and_secrets/test/positive53.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Contributor
|
KICS version: v2.1.11
|
cx-artur-ribeiro
approved these changes
Aug 27, 2025
cx-artur-ribeiro
left a comment
cx-artur-ribeiro
left a comment
Contributor
There was a problem hiding this comment.
LGTM, good catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Reason for Proposed Changes
negative5.tffrom the query "IAM DB Cluster Auth Not Enabled" has the fieldiam_database_authentication_enabledset to true, which should be set to false, as this is the case that this sample aims to cover(does not return a positive result because it has an engine_version invalid version for the mariadb engine).Proposed Changes
iam_database_authentication_enabledfrom true to false.I submit this contribution under the Apache-2.0 license.