Skip to content

fix(query): added module support for "iam_db_cluster_auth_not_enabled" query#7675

Merged
cx-artur-ribeiro merged 30 commits into
masterfrom
AST-40745
Aug 26, 2025
Merged

fix(query): added module support for "iam_db_cluster_auth_not_enabled" query#7675
cx-artur-ribeiro merged 30 commits into
masterfrom
AST-40745

Conversation

@cx-ricardo-jesus

@cx-ricardo-jesus cx-ricardo-jesus commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Closes #

Reason for Proposed Changes

  • The query "IAM DB Cluster Auth Not Enabled" for the Terraform platform does not have support for the module that is equivalent to the aws_rds_cluster.
  • Some cases are not covered by the samples in both CloudFormation and Terraform platforms.

Proposed Changes

  • Created two more policies, the first one checks if the field iam_database_authentication_enabled is not defined, and the second one checks if the field is defined to false.
  • Added module samples.
  • Added more samples to the CloudFormation, also.
  • Changed the second verification on the helper function for both query implementations.

I submit this contribution under the Apache-2.0 license.

cx-andre-pereira and others added 27 commits July 24, 2025 12:23
…dformation/aws' of https://github.com/cx-andre-pereira/kics into AST-40783--FN_CloudFormation_Boolean_Logic_Update--cloudformation/aws
@cx-ricardo-jesus cx-ricardo-jesus requested a review from a team as a code owner August 26, 2025 10:30
@github-actions github-actions Bot added query New query feature terraform Terraform query labels Aug 26, 2025
@github-actions github-actions Bot added the aws PR related with AWS Cloud label Aug 26, 2025
@gitguardian

gitguardian Bot commented Aug 26, 2025

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
19562607 Triggered Generic Password 5cbea1a assets/queries/common/passwords_and_secrets/test/positive53.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.11

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-ricardo-jesus cx-ricardo-jesus marked this pull request as draft August 26, 2025 10:42
@github-actions github-actions Bot added the cloudformation CloudFormation query label Aug 26, 2025
@cx-ricardo-jesus cx-ricardo-jesus marked this pull request as ready for review August 26, 2025 11:06

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-artur-ribeiro cx-artur-ribeiro merged commit b597e17 into master Aug 26, 2025
30 of 31 checks passed
@cx-artur-ribeiro cx-artur-ribeiro deleted the AST-40745 branch August 26, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws PR related with AWS Cloud cloudformation CloudFormation query query New query feature terraform Terraform query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants