Skip to content

test(query): add missing test case for S3 Bucket Allows Public Policy#7664

Merged
cx-artur-ribeiro merged 2 commits into
masterfrom
AST-105689
Aug 20, 2025
Merged

test(query): add missing test case for S3 Bucket Allows Public Policy#7664
cx-artur-ribeiro merged 2 commits into
masterfrom
AST-105689

Conversation

@cx-romeu-silva

@cx-romeu-silva cx-romeu-silva commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reason for Proposed Changes

  • The current query includes all test cases except the positive case where an aws_s3_account_public_access_block resource is defined, its block_public_policy field is missing, and no aws_s3_bucket_public_access_block resource is defined.

Proposed Changes

  • Add the missing positive test case.

I submit this contribution under the Apache-2.0 license.

@cx-romeu-silva cx-romeu-silva requested a review from a team as a code owner August 20, 2025 12:08
@github-actions github-actions Bot added community Community contribution query New query feature aws PR related with AWS Cloud labels Aug 20, 2025
@github-actions

github-actions Bot commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.11

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

cx-artur-ribeiro
cx-artur-ribeiro approved these changes Aug 20, 2025
View reviewed changes

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-artur-ribeiro cx-artur-ribeiro merged commit 5d8ad60 into master Aug 20, 2025
27 checks passed
@cx-artur-ribeiro cx-artur-ribeiro deleted the AST-105689 branch August 20, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cx-artur-ribeiro cx-artur-ribeiro cx-artur-ribeiro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cx-romeu-silva cx-romeu-silva

Labels

aws PR related with AWS Cloud community Community contribution query New query feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cx-romeu-silva @cx-artur-ribeiro