Skip to content

test(query): fixed negative tests for "Storage Share File Allows All ACL Permissions" - terraform/azure#7660

Merged
cx-artur-ribeiro merged 5 commits into
masterfrom
AST-40740-new_negative_tests_for_Storage_Share_File_Allows_All_ACL_Permissions--ARM
Aug 21, 2025
Merged

test(query): fixed negative tests for "Storage Share File Allows All ACL Permissions" - terraform/azure#7660
cx-artur-ribeiro merged 5 commits into
masterfrom
AST-40740-new_negative_tests_for_Storage_Share_File_Allows_All_ACL_Permissions--ARM

Conversation

@cx-andre-pereira

@cx-andre-pereira cx-andre-pereira commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Reason for Proposed Changes

Proposed Changes

  • Replaced the old negative test with 2 new test that will check that the query does not flag in case:
    • The azurerm_storage_share is not referenced by a azurerm_storage_share_file resource
    • The azurerm_storage_share.access_policy.permissions are not equal to "rwdl".
  • Changed the positive test slightly.

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions Bot added query New query feature terraform Terraform query azure PR related with Azure Cloud labels Aug 19, 2025
@github-actions

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.11

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-andre-pereira cx-andre-pereira marked this pull request as ready for review August 19, 2025 15:07
@cx-andre-pereira cx-andre-pereira requested a review from a team as a code owner August 19, 2025 15:07

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-artur-ribeiro cx-artur-ribeiro merged commit fdc3814 into master Aug 21, 2025
27 checks passed
@cx-artur-ribeiro cx-artur-ribeiro deleted the AST-40740-new_negative_tests_for_Storage_Share_File_Allows_All_ACL_Permissions--ARM branch August 21, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure PR related with Azure Cloud query New query feature terraform Terraform query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants