Skip to content

test(query): added extra tests to "Security Group Not Used" query for terraform/aws#7641

Merged
cx-ricardo-jesus merged 2 commits into
masterfrom
AST-65314
Aug 13, 2025
Merged

test(query): added extra tests to "Security Group Not Used" query for terraform/aws#7641
cx-ricardo-jesus merged 2 commits into
masterfrom
AST-65314

Conversation

@cx-ricardo-jesus

@cx-ricardo-jesus cx-ricardo-jesus commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

Reason for Proposed Changes

  • The samples did not had into account that the references to the security groups inside the resources provided on the tests can be inside the "" characters and vice-versa.

Proposed Changes

  • Added the extra cases regarding the negative and the positive samples.

I submit this contribution under the Apache-2.0 license.

@cx-ricardo-jesus cx-ricardo-jesus requested a review from a team as a code owner August 11, 2025 16:48
@github-actions github-actions Bot added query New query feature terraform Terraform query aws PR related with AWS Cloud labels Aug 11, 2025
@github-actions

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.11

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice addition

@cx-ricardo-jesus cx-ricardo-jesus merged commit aedbe14 into master Aug 13, 2025
27 of 28 checks passed
@cx-ricardo-jesus cx-ricardo-jesus deleted the AST-65314 branch August 13, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws PR related with AWS Cloud query New query feature terraform Terraform query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants