fix(progressbar): fix flaky TestCounter_Start unit test#7573
Merged
Conversation
Contributor
cx-rui-araujo
left a comment
Contributor
There was a problem hiding this comment.
@cx-artur-ribeiro check my comment
cx-miguel-dasilva
suggested changes
Jul 18, 2025
cx-miguel-dasilva
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Reason for Proposed Changes
TestCounter_Startrandomly failed due to race condition and off-by-one error;Proposed Changes
Start()caused by the progress channel closing.Example Error
=== RUN TestCounter_Start/test_counter_progress_bar
counter_progress_test.go:52:
Error Trace: /home/runner/work/kics/kics/pkg/progress/counter/counter_progress_test.go:52
Error: Not equal:
expected: 9
actual : 10
Test: TestCounter_Start/test_counter_progress_bar
I submit this contribution under the Apache-2.0 license.