Skip to content

feat(query): added new query: ElasticSearch Without Audit Logs - cloudFormation/aws#7565

Merged
cx-andre-pereira merged 11 commits into
Checkmarx:masterfrom
cx-andre-pereira:AST-45508--FN_ElasticSearch_Without_Audio_Logs--cloudFormation/aws
Aug 13, 2025
Merged

feat(query): added new query: ElasticSearch Without Audit Logs - cloudFormation/aws#7565
cx-andre-pereira merged 11 commits into
Checkmarx:masterfrom
cx-andre-pereira:AST-45508--FN_ElasticSearch_Without_Audio_Logs--cloudFormation/aws

Conversation

@cx-andre-pereira

@cx-andre-pereira cx-andre-pereira commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

Reason for Proposed Changes

  • Currently there is no check for the Audit Logs of Elasticsearch CloudFormation resources to be set to true.
  • There is a very similar query for "slow logs" already implemented.
  • It is to note this query does check for more than a since resource type, those being: "AWS::OpenSearchService::Domain" and "AWS::Elasticsearch::Domain"; both have equivalent LogPublishingOption fields which define whether the audit logs are enabled or not through the "AUDIT_LOGS" key.

Proposed Changes

  • I simply altered the slow logs query to account for audit logs instead.
  • The tests are also based on the slow logs query with simple alteration of some fields to fit the context of the new query, plus some tests for the "AWS::OpenSearchService::Domain" resource type.

I submit this contribution under the Apache-2.0 license.

AndrePereira123 and others added 2 commits July 16, 2025 12:56
…out Audit Logs - id: c420748a-bd4a-46c8-9541-93dd1e0ccf38
@cx-andre-pereira cx-andre-pereira requested a review from a team as a code owner July 16, 2025 11:58
@github-actions github-actions Bot added community Community contribution feature request Community: new feature request query New query feature cloudformation CloudFormation query aws PR related with AWS Cloud labels Jul 16, 2025
@github-actions github-actions Bot added the feature New feature label Jul 28, 2025
@Checkmarx Checkmarx deleted a comment from gitguardian Bot Aug 7, 2025
@Checkmarx Checkmarx deleted a comment from gitguardian Bot Aug 13, 2025

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Checkmarx Checkmarx deleted a comment from gitguardian Bot Aug 13, 2025
@cx-andre-pereira cx-andre-pereira merged commit 5161577 into Checkmarx:master Aug 13, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws PR related with AWS Cloud cloudformation CloudFormation query community Community contribution feature request Community: new feature request feature New feature query New query feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants