fix(query): fix fp for api_gateway_method_does_not_contains_an_api_key#7557
Merged
Conversation
…Contains_An_API_Key--terraform/aws
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Proposed Changes
api_key_requiredfield or sets it to a value other thantrue.Proposed Changes
api_key_requiredvalue.Note: it was considered an extra check to ensure the field is actually set to false if the HTTP method is "OPTIONS", but due to not representing a security flaw / representing an idea that directly opposes the objective of this query (i.e. guaranteeing a field is set to
falsewhen the whole purpose of the query is assuring it is set totrue).originalPR
I submit this contribution under the Apache-2.0 license.