fix(query): fix fp for s3_bucket_logging_disabled#7535
Closed
cx-andre-pereira wants to merge 2 commits into
Closed
fix(query): fix fp for s3_bucket_logging_disabled#7535cx-andre-pereira wants to merge 2 commits into
cx-andre-pereira wants to merge 2 commits into
Conversation
cx-artur-ribeiro
approved these changes
Jul 14, 2025
cx-artur-ribeiro
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7515
Reason for Proposed Changes
Proposed Changes
is_logging_targetpolicy that ensures buckets that are referenced as logging targets for another bucket do not get flagged.Note : There could be a need for a similar implementation on "module" type bucket declaration (negative2 / positive2), but i could not replicate this false positive detection with that declaration structure.
I submit this contribution under the Apache-2.0 license.