fix(query): fix fp in password and secrets Generic Passwords

[cx-romeu-silva]

Reason for Proposed Changes

• The rule "Generic Password" is currently flagging some cases that do not represent actual vulnerabilities:

  • Placeholders: While it's context-dependent whether a value is a placeholder, the likelihood of it being a real password is very low compared to how often it's a false positive. Common placeholder delimiters include $(...), ${{...}} and {{...}}.

    vmAdminPassword: '$(VM_ADMIN_PASSWORD)'
    sqlAdminPassword: '$(SQL_ADMIN_PASSWORD)'
    yetanotherAdminPassword: '${{SQL_ADMIN_PASSWORD}}'
    andyetanotherAdminPassword: '${{ SQL_ADMIN_PASSWORD }}'

  • Empty values: The password/secret is not hardcoded, so it should not be flagged.

    anotherAdminPassword: ''

Proposed Changes

• Add rules to the allowRules section of the "Generic Password" rule to Allow placeholder patterns and Exclude empty string values.

I submit this contribution under the Apache-2.0 license.

[github-actions]

KICS version: v2.1.7

Category Results CRITICAL 0 HIGH 0 MEDIUM 0 LOW 0 INFO 0 TRACE 0 TOTAL 0	Metric Values Files scanned 1 Files parsed 1 Files failed to scan 0 Total executed queries 47 Queries failed to execute 0 Execution time 0

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
4266028	Triggered	Generic Password	6180751	assets/queries/terraform/azure/mssql_server_auditing_disabled/test/positive2.tf	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[cx-miguel-dasilva]

LGTM 🚀