fix(query): fix fn for s3_bucket_without_restriction_of_public_bucket

[cx-romeu-silva]

Reason for Proposed Changes

• The query currently only checks the s3_bucket_public_access_block resource and does not account for the s3_account_public_access_block, which also has the restrict_public_buckets attribute and can affect the effective configuration.
• This is similar to the issue fixed in fix(query): fix fn for S3_Bucket_Allows_Public_Policy query #7456, but applied to the restrict_public_buckets attribute instead of block_public_policy.

Proposed Changes

• Taking a similar approach to fix(query): fix fn for S3_Bucket_Allows_Public_Policy query #7456, the rule (S3 Bucket Without Restriction of Public Bucket) flags a result if and only if:
  • aws_s3_account_public_access_block is defined, but does not explicitly set restrict_public_buckets = true, and
  • aws_s3_bucket_public_access_block explicitly sets restrict_public_buckets = false.

I submit this contribution under the Apache-2.0 license.

[github-actions]

KICS version: v2.1.11

Category Results CRITICAL 0 HIGH 0 MEDIUM 0 LOW 0 INFO 0 TRACE 0 TOTAL 0	Metric Values Files scanned 1 Files parsed 1 Files failed to scan 0 Total executed queries 47 Queries failed to execute 0 Execution time 0

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
4266028	Triggered	Generic Password	aca4126	assets/queries/terraform/azure/mssql_server_auditing_disabled/test/positive2.tf	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[cx-artur-ribeiro]

LGTM! Nice work Romeu

[cx-eduardo-semanas]

LGTM