Repository navigation
feat: support EIP-8261 gas limit schedule - #9808
Merged
Merged
Conversation
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Member
Author
|
ethereum/EIPs#12142 to align the EIP with our implementation |
nflaig
marked this pull request as ready for review
August 11, 2026 12:22
nflaig
added a commit
that referenced
this pull request
Aug 11, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 372bef369b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
Author
|
merged into |
nflaig
added a commit
that referenced
this pull request
Aug 11, 2026
nflaig
added a commit
that referenced
this pull request
Aug 11, 2026
spiral-ladder
left a comment
spiral-ladder
left a comment
Member
There was a problem hiding this comment.
do we need to update keyManager's getGasLimit as well?
| continue; | ||
| } | ||
|
|
||
| if (key === "BLOB_SCHEDULE") { |
Member
There was a problem hiding this comment.
we validate BLOB_SCHEDULE, should we validate GAS_LIMIT_SCHEDULE?
Member
Author
There was a problem hiding this comment.
for the blob schedule we wanna make sure that beacon node <> validator client have same config, however the gas limit schedule is only relevant for the validator client as the beacon node doesn't do anything with this config other than return it via config/spec endpoint, that's why I set GAS_LIMIT_SCHEDULE: false further below
we could still do it if we really wanted to but I am thinking this could cause more headaches than provide actual value if clients have config mismatches for some reason
Member
Author
doesn't |
Member
we don't pass |
Member
Author
ah this is a good catch, we should probably just default to current slot if queried via keymanager api |
nflaig
commented
Aug 12, 2026
| private readonly config: BeaconConfig; | ||
| private readonly api: ApiClient; | ||
| private readonly clock: IClock; | ||
| readonly clock: IClock; |
Member
Author
There was a problem hiding this comment.
not so happy about that but was cleanest way to access current slot in keymanager api
spiral-ladder
previously approved these changes
Aug 13, 2026
Member
Author
|
keeping this open, there will be a decision on ACDE today whether or not clients should adopt this |
nflaig
commented
Aug 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9808 +/- ##
============================================
+ Coverage 52.46% 52.59% +0.13%
============================================
Files 848 848
Lines 62953 59989 -2964
Branches 4658 4416 -242
============================================
- Hits 33030 31554 -1476
+ Misses 29855 28376 -1479
+ Partials 68 59 -9 🚀 New features to boost your workflow:
|
nflaig
commented
Aug 13, 2026
| throw Error(`Invalid GAS_LIMIT_SCHEDULE value ${input} expected array`); | ||
| } | ||
|
|
||
| const gasLimitSchedule = input.map((entry, i) => { |
Member
Author
There was a problem hiding this comment.
maybe we can check here if any epoch is < GLOAS_FORK_EPOCH but I don't think that's possible
Member
Author
There was a problem hiding this comment.
this was kinda simple so I added that sanity check here e65c5fa
matthewkeil
approved these changes
Aug 13, 2026
matthewkeil
left a comment
matthewkeil
left a comment
Member
There was a problem hiding this comment.
LGTM!! 🎸
Sent some feedback via DM and all were resolved
matthewkeil
enabled auto-merge (squash)
August 13, 2026 16:55
nflaig
disabled auto-merge
August 13, 2026 17:07
nflaig
enabled auto-merge (squash)
August 13, 2026 17:08
github-project-automation
Bot
moved this from In Progress
to Done
in Lodestar Team Coordination
Member
|
🎉 This PR is included in v1.47.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements EIP-8261 as an advisory epoch-based gas limit schedule
GAS_LIMIT_SCHEDULEconfig parsing, serialization, validation and epoch lookupSee ethereum/consensus-specs#5533