feat: clean up fulu peer connected event#8157
Merged
Merged
Conversation
nflaig
reviewed
Aug 8, 2025
| return hex.startsWith("0x") ? hex.slice(2) : hex; | ||
| } | ||
|
|
||
| export function getCustodyGroupIncrements(custodyGroups: number[]): string[] { |
Member
There was a problem hiding this comment.
why is this in utils package? this seems beacon-node specific
Member
There was a problem hiding this comment.
yea agree it can go under beacon-node/src/utils if you want
Member
Author
There was a problem hiding this comment.
made it more generic so it works with any indices (sparse, unsorted, duplicated, etc) so we can use for slot ranges or others in all packages
nflaig
reviewed
Aug 10, 2025
|
|
||
| it("should handle full range 0-127", () => { | ||
| const fullRange = Array.from({length: 128}, (_, i) => i); | ||
| expect(getCustodyGroupIncrements(fullRange)).toEqual(["0-127"]); |
Member
There was a problem hiding this comment.
this is nice, right now the log, especially for supernodes is way to verbose
wemeetagain
approved these changes
Aug 11, 2025
Member
|
🎉 This PR is included in v1.34.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses
peerDASPR comment#6353 (comment)
Also clean up usage (emission and consumption) of the
peer_connectedevent.Add helper function to
prettyPrintCustodyGroups