fix: split getBlobs into V1 and V2 implementations#8140
Merged
Conversation
matthewkeil
added
the
status-do-not-merge
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## unstable #8140 +/- ##
============================================
+ Coverage 54.22% 54.24% +0.02%
============================================
Files 843 843
Lines 63365 63343 -22
Branches 4795 4796 +1
============================================
+ Hits 34361 34362 +1
+ Misses 28928 28905 -23
Partials 76 76 🚀 New features to boost your workflow:
|
nflaig
reviewed
Aug 10, 2025
Member
|
generally looks good, what is missing to convert from draft? |
Member
would like that we remove the retry mechanism, this will simplify things a bit |
Member
Author
Need to incorporate the research Katya found and remove the retry that nico suggested. Will handle this after the EF call |
… remove timeout/retry
matthewkeil
removed
the
status-do-not-merge
wemeetagain
approved these changes
Aug 11, 2025
wemeetagain
approved these changes
Aug 11, 2025
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
reviewed
Aug 12, 2025
Comment on lines
+536
to
+537
| this.logger.error(error); | ||
| throw Error(error); |
Member
There was a problem hiding this comment.
why do we need to log and throw? isn't it logged upstream already?
Member
|
🎉 This PR is included in v1.34.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses peerDAS PR comment
#6353 (comment)