feat: add gperftools mise script#7063
Conversation
WalkthroughThis PR adds profiling infrastructure for gperftools-based memory heap analysis in Forest binaries. It adjusts the profiling profile optimization level, ensures the build script reruns on profiling configuration changes, and introduces a Bash utility script that orchestrates building and executing binaries under heap profiling collection. ChangesProfiling Infrastructure
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
e4622a5 to
02ab460
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@mise-tasks/gperf/heap.sh`:
- Line 36: The script currently calls ulimit -n 8192 in mise-tasks/gperf/heap.sh
which will cause the whole script to exit under set -e if the hard limit is
lower; change this to a best-effort attempt that does not hard-fail (e.g. run
the ulimit call in a conditional or append a fallback so failure only emits a
warning). Update the ulimit invocation (the "ulimit -n 8192" line) to check its
exit status and print a warning via echo or printf if it fails, but continue
execution (do not remove set -e).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 3949e8e9-47c7-40e2-a3f6-ce9015981a35
📒 Files selected for processing (3)
Cargo.tomlbuild.rsmise-tasks/gperf/heap.sh
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary of changes
Make gperftools run not a hassle anymore
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
New Features
Chores