chore: no skipping keystore encryption in docs by default#6549
Merged
Conversation
Contributor
WalkthroughRemoved explicit Changes
Sequence Diagram(s)(Skipped — changes are documentation-only and do not introduce new multi-component control flow.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@README.md`:
- Around line 233-236: Search the repository for all occurrences of the literal
flag "--encrypt-keystore false" (including the ones noted in README.md and docs)
and remove them; instead update those docs to instruct users to omit the
insecure flag and to use secure keystore encryption via environment variables
such as FOREST_KEYSTORE_PHRASE or a secrets manager (or show the proper CLI
usage without the insecure flag), and update any example commands or guides that
referenced the flag to demonstrate setting FOREST_KEYSTORE_PHRASE or using a
secrets workflow.
hanabi1224
previously approved these changes
Feb 5, 2026
hanabi1224
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #6548
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit