bridge exec benches: recording rules for always-fresh sparse-run values - #2325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 'value blank between daily runs' display issue on benches 261/263. The execution metrics run ~once/day so the raw gauges go Prom-stale and instant queries (what the materializer effectively needs) see nothing. Add ocb: recording rules (quantile_over_time / avg_over_time re-evaluated every 30s, labels preserved) so a fresh value is always present, and point bench 261 (latency) + 263 (slippage/gas/realized + panels) at them. Rules are live on ocb-prom (/opt/ocb/prom-rules/ocb_bridge_execution.yml) and tracked here under infrastructure/monitoring. Verified: mobula 5529 / relay 5456 / lifi 6257 / near-intents 37839 ms, fresh + instant-queryable. Specs validate.