Skip to content

series: densify 90d/1y so young benches show all data #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 1 commit into from
Sep 10, 2026
Merged

series: densify 90d/1y so young benches show all data #2313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/app/api/series/[slug]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,12 @@ const getSeriesMapCached = unstable_cache(
const prom = new Prometheus(promUrl);

const windowSec = range === "90d" ? 90 * 86_400 : 365 * 86_400;
// ~1 point per day for 90d, ~3 days per point for 1y — dense enough
// for a smooth bar-chart race without blowing Prom step budgets.
const numPoints = range === "90d" ? 90 : 120;
// Resolution, not a fixed point budget: ~6h step for 90d, ~18h for 1y.
// A fixed low point count (90 / 120) collapsed young benches — 23 days of
// data rendered as ~24 points on 90d and ~8 on 1y, so a fresh bench looked
// like a sliver near "now". Stepping by time instead means every day of
// available history shows at full fidelity regardless of the window width.
const numPoints = range === "90d" ? 360 : 480;

const result: Record<string, (number | null)[]> = {};
await Promise.all(
Expand All @@ -135,8 +138,8 @@ const getSeriesMapCached = unstable_cache(

return Object.keys(result).length > 0 ? result : null;
},
// v7: targeted Prom fallback for panel 7d/30d misses (avoids specToBenchmark O(providers×panels)).
["series-by-range-v7"],
// v8: denser 90d/1y resolution (6h / 18h step) so young benches render at full fidelity.
["series-by-range-v8"],
{ revalidate: 300, tags: ["benchmarks"] },
);

Expand All @@ -160,8 +163,8 @@ const RANGE_CONFIG = {
"24h": { windowMs: 24 * 3600 * 1000, points: 72 },
"7d": { windowMs: 7 * 24 * 3600 * 1000, points: 84 },
"30d": { windowMs: 30 * 24 * 3600 * 1000, points: 60 },
"90d": { windowMs: 90 * 24 * 3600 * 1000, points: 90 },
"1y": { windowMs: 365 * 24 * 3600 * 1000, points: 120 },
"90d": { windowMs: 90 * 24 * 3600 * 1000, points: 360 },
"1y": { windowMs: 365 * 24 * 3600 * 1000, points: 480 },
} as const;

type RangeKey = keyof typeof RANGE_CONFIG;
Expand Down
Loading