fix: include pre-window HL positions in Gains carry projection - #2121
Merged
Merged
Conversation
* feat: HL vs Gains wallet fee comparison tool * feat: HL vs Gains wallet fee comparison * fix: fetch Gains fee rates live, drop hardcoded 0.12% * fix: fetch Gains fee rates live, drop hardcoded rates * feat: HL vs Gains wallet fee comparison tool * fix: fetch Gains fee rates live, drop hardcoded 0.12% * feat: per-trade table, live Gains rates per coin, PnL column * fix: remove duplicate gainsFeeCache declaration * feat: fee-compare per-trade breakdown + live Gains rates * feat: HL vs Gains wallet fee comparison tool * fix: fetch Gains fee rates live, drop hardcoded 0.12% * feat: per-trade table, live Gains rates per coin, PnL column * fix: remove duplicate gainsFeeCache declaration * redesign: fee-compare UI — logos, VS card, trade table, per-fill savings (#2046) * perf: reduce Vercel invocations - live-prices 1s->5s CDN TTL, alternatives+perp ISR 300s * fix: double-counted notional in HL vs Gains comparison (#2048) * redesign: fee-compare UI — logos, VS card, trade table, per-fill savings * fix: double-counted notional in HL vs Gains comparison — use per-side rate * fix: rename Gains.trade -> Gains, HL -> Hyperliquid in UI (#2049) * feat: always show Gains simulated, bold winner, pro design (#2051) * fix: mobile responsive — stack VS card vertically, hide overflow columns (#2052) * fix: symmetric HL/Gains display + winner logic for single-platform wallets (#2053)
fix: sitemap 90s timeout — maxDuration=60, internal deadline 20s
…etProvider throws
fix: sitemap 500 — orphan rejection + unhandled getProvider throws
feat(rpc): dogecoin bench #235 → main (hotfix)
fix(dogecoin-rpc): em-dash breaks spec validation
fix(dogecoin-rpc): em-dash breaks spec validation
* feat: shareable wallet URLs + HL fee/funding breakdown - /fee-compare/[venueA]/[venueB]/[wallet] dynamic route auto-submits on load - pushState updates URL after analyze so any comparison is shareable - FeeCompareClient accepts initialVenueA/B/Wallet/Days props - HL wallet side: replace 2-cell grid with inline fee/funding/net breakdown * fix: remove 'No activity found' text from crossSim projection side * fix: sitemap aggregate timeout + CDN caching (s-maxage stripped by dynamic route)
SIGKILL (signal 9) was killing the function at 60s. The aggregate blob (4.25MB) exceeds Next.js Data Cache's 2MB cap, so unstable_cache never caches it and every request re-fetches from /api/aggregate (FETCH_TIMEOUT_MS = 65s > maxDuration = 60s). SIGKILL discards the buffered response -> 500. - maxDuration 60 -> 300: gives full build time on cold starts - JS timeout 55s -> 240s: allows aggregate fetch + HL-builder Prometheus sweeps to finish before falling back to the static sitemap
feat(zcash): bench #236 Tatum zcashd + Tatum Zebra + Blockchair
fix: raise maxDuration to 300s, extend sitemap JS timeout to 240s
ship: dev to main (aug 27)
bakabhai993
pushed a commit
to bakabhai993/OpenChainBench
that referenced
this pull request
Sep 12, 2026
…Bench#2121) * feat: fee-compare tool — Hyperliquid vs Gains wallet analysis (ChainBench#2054) * feat: HL vs Gains wallet fee comparison tool * feat: HL vs Gains wallet fee comparison * fix: fetch Gains fee rates live, drop hardcoded 0.12% * fix: fetch Gains fee rates live, drop hardcoded rates * feat: HL vs Gains wallet fee comparison tool * fix: fetch Gains fee rates live, drop hardcoded 0.12% * feat: per-trade table, live Gains rates per coin, PnL column * fix: remove duplicate gainsFeeCache declaration * feat: fee-compare per-trade breakdown + live Gains rates * feat: HL vs Gains wallet fee comparison tool * fix: fetch Gains fee rates live, drop hardcoded 0.12% * feat: per-trade table, live Gains rates per coin, PnL column * fix: remove duplicate gainsFeeCache declaration * redesign: fee-compare UI — logos, VS card, trade table, per-fill savings (ChainBench#2046) * perf: reduce Vercel invocations - live-prices 1s->5s CDN TTL, alternatives+perp ISR 300s * fix: double-counted notional in HL vs Gains comparison (ChainBench#2048) * redesign: fee-compare UI — logos, VS card, trade table, per-fill savings * fix: double-counted notional in HL vs Gains comparison — use per-side rate * fix: rename Gains.trade -> Gains, HL -> Hyperliquid in UI (ChainBench#2049) * feat: always show Gains simulated, bold winner, pro design (ChainBench#2051) * fix: mobile responsive — stack VS card vertically, hide overflow columns (ChainBench#2052) * fix: symmetric HL/Gains display + winner logic for single-platform wallets (ChainBench#2053) * fix: mobile table Gains fee column always visible, symmetric panels (ChainBench#2057) * fix: revalidate hl-cohort + hl-history on aggregate purge (ChainBench#2069) * fix(app-store-ratings): last_over_time[31m] on reviews panel for 7d+ staleness (ChainBench#2073) * fix: sitemap 90s timeout — maxDuration=60 + tighten internal deadline to 20s * fix: suppress orphaned buildFullSitemap rejection + guard unhandled getProvider throws * feat(rpc): add Dogecoin bench ChainBench#235 (Tatum, dRPC, BlockCypher) * fix(dogecoin-rpc): remove em-dash from seo_intro * fix(dogecoin-rpc): em-dash in seo_intro * fix: sitemap aggregate timeout + CDN caching (ChainBench#2090) (ChainBench#2092) * feat: shareable wallet URLs + HL fee/funding breakdown - /fee-compare/[venueA]/[venueB]/[wallet] dynamic route auto-submits on load - pushState updates URL after analyze so any comparison is shareable - FeeCompareClient accepts initialVenueA/B/Wallet/Days props - HL wallet side: replace 2-cell grid with inline fee/funding/net breakdown * fix: remove 'No activity found' text from crossSim projection side * fix: sitemap aggregate timeout + CDN caching (s-maxage stripped by dynamic route) * fix: raise maxDuration to 300s and extend sitemap JS timeout to 240s SIGKILL (signal 9) was killing the function at 60s. The aggregate blob (4.25MB) exceeds Next.js Data Cache's 2MB cap, so unstable_cache never caches it and every request re-fetches from /api/aggregate (FETCH_TIMEOUT_MS = 65s > maxDuration = 60s). SIGKILL discards the buffered response -> 500. - maxDuration 60 -> 300: gives full build time on cold starts - JS timeout 55s -> 240s: allows aggregate fetch + HL-builder Prometheus sweeps to finish before falling back to the static sitemap * feat(zcash): add bench ChainBench#236 with Tatum zcashd, Tatum Zebra, Blockchair * fix: include pre-window HL positions in carry projection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reconstructHlPositions was filtering fills to >= cutoffMs upfront, missing positions opened before the window. These positions still generate HL funding events (correctly captured) but had zero carry in the Gains projection. Fix: process all fills chronologically, cap slice.openMs to cutoffMs.