fix: gains funding precision 1e21 (1000x correction) - #2113
Merged
Merged
Conversation
bakabhai993
pushed a commit
to bakabhai993/OpenChainBench
that referenced
this pull request
Sep 12, 2026
* fix: Gains USDC collateral array index (2 not 3) * feat: fallback Gains funding estimate when API returns zero * fix: gains funding precision 1e21 not 1e18 (1000x correction)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lastFundingRatePerSecondPuses 1e21 precision, not 1e18. Was causing Gains funding estimates to be 1000x too high in crossSim projections and the fallback estimation.Verified empirically: HL BTC funding = 4.51e-10/sec; Gains BTC at 1e21 = 4.47e-10/sec (within 1%). At 1e18 it was 4.47e-7/sec (990x off).