fix: Gains USDC collateral array index - #2111
Merged
Merged
Conversation
Flotapponnier
force-pushed
the
feat/fee-compare-carry-v2
branch
from
August 27, 2026 13:03
0c54bb3 to
35ad732
Compare
bakabhai993
pushed a commit
to bakabhai993/OpenChainBench
that referenced
this pull request
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
GAINS_USDC_COLLATERAL_IDX = 3was using the wrong array index.The
vars.collateralsarray is 0-indexed:We were reading GNS borrow/funding rates and applying them to USDC trades.
Fix
Change constant from
3to2.Note: the
collateralIndex === 3filter infetchGainsTradesis correct — it refers to thecollateralIndexfield value (1-indexed) on individual trade objects, not the array position.