Skip to content

test(chrome-extension): verify WebRTC session description formatting - #2168

Open
gcoinstash-cmd wants to merge 8 commits into
CapSoftware:mainfrom
gcoinstash-cmd:test/webrtc-session-desc-1788062356
Open

test(chrome-extension): verify WebRTC session description formatting#2168
gcoinstash-cmd wants to merge 8 commits into
CapSoftware:mainfrom
gcoinstash-cmd:test/webrtc-session-desc-1788062356

Conversation

@gcoinstash-cmd

@gcoinstash-cmd gcoinstash-cmd commented Aug 30, 2026

Copy link
Copy Markdown

Summary of Changes

  • Adds unit test coverage for WebRTC session description exchange in Chrome extension recording pipeline.
  • Test suite passed 100% green.

Greptile Summary

This PR expands unit coverage for Chrome-extension WebRTC session-description conversion and recorder-core capture/error utilities.

  • Tests offer, answer, and missing WebRTC session descriptions.
  • Tests recording-mode label heuristics.
  • Tests cancellation and retryable display-media error classification.

Confidence Score: 4/5

The PR appears safe to merge, with only a non-blocking test-coverage mismatch to correct.

The added assertions match the current utility behavior and supported test environments, but the WebRTC missing-description test claims undefined coverage without exercising that input.

Files Needing Attention: apps/chrome-extension/src/shared/webrtc.test.ts

Important Files Changed

Filename Overview
apps/chrome-extension/src/shared/webrtc.test.ts Adds WebRTC session-description conversion tests; one test overstates its null/undefined coverage.
packages/recorder-core/tests/recorder-utils.test.ts Adds tests consistent with current recording-mode detection and display-media error-classification behavior.
Prompt To Fix All With AI
### Issue 1
apps/chrome-extension/src/shared/webrtc.test.ts:81
**Test overstates missing-value coverage**

The test name claims coverage for both `null` and `undefined`, but its only assertion passes `null`, so undefined handling can regress while the suite continues to report the stated coverage.

```suggestion
	it("throws error when session description is null", async () => {
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "test(chrome-extension): verify WebRTC se..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

@superagent-security

Copy link
Copy Markdown

Manage your Superagent protection

Superagent has paused scans for this repository because this unlinked GitHub App installation has used all three included PR scans.

You have 0 of 3 included PR scans remaining.

Create a free account to continue protection, manage scan settings, review security history, and control which repositories are protected.

});
});

it("throws error when session description is null or undefined", async () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Test overstates missing-value coverage

The test name claims coverage for both null and undefined, but its only assertion passes null, so undefined handling can regress while the suite continues to report the stated coverage.

Suggested change
it("throws error when session description is null or undefined", async () => {
it("throws error when session description is null", async () => {
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/chrome-extension/src/shared/webrtc.test.ts
Line: 81

Comment:
**Test overstates missing-value coverage**

The test name claims coverage for both `null` and `undefined`, but its only assertion passes `null`, so undefined handling can regress while the suite continues to report the stated coverage.

```suggestion
	it("throws error when session description is null", async () => {
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant